wow, txs for that review. I personally think sirona can be something which is really interesting. But the code is pretty hardcore and thus we do hard in reaching 'starters'. Not sure how to improve this...
LieGrue, strub On Wednesday, 25 June 2014, 9:25, Justin Mclean <jus...@classsoftware.com> wrote: > > >Hi, > >Sorry I been a bit busy with travel and other releases over the last few weeks. > >-1 binding due to vote issues, NOTICE and binaries in source release. > >I checked: >- missing VOTE RESULT and can't tell if there are 3 +1 binding votes or not. >There are 4 +1 votes on of which one is not binding but unsure re the others. >Only one of the +1 votes is listed as a PMC member here [1] and the project is >not listed here [2]. >- artefact name includes incubating >- signatures and md5 hash all good >- DISCLAIMER present >- LICENSE correct >- NOTICE file includes too many things (see below) >- binary files in source release (see bleow) >- can compile from source >- test failed (JavaAgent) - up to you if you think this is an issue or not > >In the NOTICE file you have: >SB Admin Theme (Apache) >Twitter bootstrap (MIT) >Bootstrap datetimepicker (Apache) >Table sorter (MIT) >JQuery (MIT) >JQuery Flot (MIT) > >As per [3] there is not need to modify the NOTICE file when bundling >permissive licenses. > >Binary file in source release. >- Font files in resources/fonts. It is unclear how there are these licensed >and where are they from. > >Some minor thing you may want to fix in future releases. >- Add a KEY file to the incubating release ares >- add "apache" to the release artefact name >- not sure that DEPENDANCIES is needed >- probably no need for LICENSE and LICENSE.txt >- Is year 2008-2013 correct in NOTICE file? >- No README (how to compile) or RELEASE_NOTES (changes form last version) >- init-git-svn.sh and siteDeploy.sh scripts are missing license header >- sb-admin.css missing license header > >The test failed with this error: >[ERROR] Failed to execute goal >org.apache.maven.plugins:maven-shade-plugin:2.1:shade (default) on project >sirona-javaagent: Error creating shaded jar: >/Users/justinmclean/Documents/Sirona0.2/apache-sirona-0.2-incubating/agent/performance/aop/target/classes > (Is a directory) -> [Help 1] > >Thanks, >Justin > >1. http://sirona.incubator.apache.org/team-list.html >2. http://people.apache.org/committers-by-project.html >3. http://www.apache.org/dev/licensing-howto.html#permissive-deps > >--------------------------------------------------------------------- >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >For additional commands, e-mail: general-h...@incubator.apache.org > > >
