Thanks Justin. I did miss the compilation instruction in the original email. The markdown file is at https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;a=blob;f=src/site/markdown/developing/building.md;h=8bf3954a73ed696868d987fef526f245b010de44;hb=master
We will also add it to the Slider homepage as a stand-alone instruction outside the release. These binary files are used for testing. Slider consumes .zip files containing application definitions to be deployed on Yarn. These files are used to unit test the ability to consume .zip files and also reject .tar files (or badly formed .zip files). Is there any way we can leave them as is? The slider-funtest module contains code to run functional test against live clusters. They are run per instructions at https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;a=blob;f=src/site/markdown/developing/functional_tests.md;h=d58c0ea4a3083d15c8438466af933465b945f7cd;hb=master The issue we need to fix is to not have the functional tests run when running "mvn test" rather have it explicitly run when proper setup exists. A JIRA is open towards this end but it was not fixed for the 0.30 release. I have created a JIRA for the other issues you have identified. -Sumit On Wed, May 28, 2014 at 7:17 PM, Justin Mclean <jus...@classsoftware.com>wrote: > Hi, > > Not sure I can vote +1 on this due to binary files in the source release - > one of which one contains jar. Is there a reason for this? > > Signatures and hashes are fine > DISCLAIMER correct > Filename contains "incubating" > NOTICE and LICENSE OK (NOTICE year may not be correct?) > Source contains binary files (see below) > Not all files have correct headers (but only a minor issue) > Had trouble compiling from source - missing instructions > Once compiled was unable to run tests (see below) > > Binary files in the source release: > > slider-0.30/slider-core/src/test/resources/org/apache/slider/common/tools/test.zip > (contains a jar) > slider-0.30/slider-core/src/test/python/appdef_1.tar > slider-0.30/slider-core/src/test/python/appdef_1.zip > > > slider-0.30/slider-core/src/test/app_packages/test_command_log/package/files/command_log_10.tar > > > slider-0.30/slider-core/src/test/app_packages/test_command_log/cmd_log_app_pkg.zip > > Looks like some of the tar files do not need to be there as their contents > are already in the source. Are these zips/tars really required? > > Was unable to get the functional tests to pass - most likely an issue at > my end but without instructions that's a little hard to tell. > [ERROR] Failed to execute goal on project slider-funtest: Could not > resolve dependencies for project org.apache.slider:slider-funtest:jar:0.30: > Failure to find org.apache.slider:slider-core:jar:tests:0.30 in > https://repository.apache.org/content/groups/staging/ was cached in the > local repository, resolution will not be reattempted until the update > interval of ASF Staging has elapsed or updates are forced -> [Help 1] > > Tried with -U and still got an error - gave up at that point. > > A few minor issues you may want to fix in a future release: > - May want to add apache to the artifact name > - A number of files are missing headers these are mostly json and python > files, I believe most of these are in bundled software (such as Jinja2) > but some are not > - LICENSE and NOTICE are preferred to LICENSE.txt and NOTICE.txt > - There's no instructions on how to build the source > - Looks like you need protobuf to compile this needs to be mentioned > somewhere > > Thanks, > Justin > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
