Hi, Thanks for reviewing!
See my replies inline. 2014-02-16 14:40 GMT+01:00 sebb <seb...@gmail.com>: > > > > > The tag to be voted upon: > > > http://svn.apache.org/repos/asf/incubator/celix/tags/celix-1.0.0.incubating/ > > The NOTICE file 2nd line says: > > Copyright [2012] The Apache Software Foundation > > This is wrong on two counts: the [ ] are not required, and the year(s) > should include more than just 2012 unless there has been no > substantive change since then. > This remarks has been made on the celix list as well, but for our mentors wasn't big enough to hold the release. Will be fixed for a next release. Is this good enough? > > > Celix's keys can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/celix/KEYS > > These should really be in the release directory, i.e > > https://dist.apache.org/repos/dist/release/incubator/celix/ > > That will ensure the file is available to downloaders from the ASF > mirror source. > I will move the files. Since this is not part of the release source/packages, is it a blocking issue? > > Which reminds me: the KEYS file needs to be linked from the download > page for use with the PGP sig. > I will add a link to the download page. > > There is a further issue with the download page. > It currently contains links for SVN. I think those don't belong on a > public download page. > SVN links should be restricted to pages intended for developers, not > the general public. > Is this common Apache policy? There are more projects who do this. Besides the website states that the SVN version is a development version, and explicitly mentions releases. Besides the NOTICE file, al others are related to items not in the release archive. Is it possible to add issues for the open points to our backlog and get a +1 so we can make the release? -- Met vriendelijke groet, Alexander Broekhuis
