On further inspection, I see the header is there, but not at the top of the file. Please move it in a future release.
-- Owen On Mon, Dec 2, 2013 at 9:56 AM, Owen O'Malley <omal...@apache.org> wrote: > +1 on the RC. I checked the signatures, looked for license headers, built, > and ran unit tests. > > For the next release, please add a license header > to > gateway-shell/src/main/java/org/apache/hadoop/gateway/shell/BasicResponse.java. > > > On Wed, Nov 27, 2013 at 4:26 PM, Devaraj Das <d...@hortonworks.com> wrote: > >> +1 on the RC. Downloaded, built and ran unit tests. >> >> >> On Mon, Nov 25, 2013 at 8:00 PM, larry mccay <lmc...@apache.org> wrote: >> >> > Hello All - >> > >> > Just to follow up on this thread, we will have these NOTICES file issues >> > corrected in the next release and assume that this VOTE will continue in >> > the absence of a -1 vote. >> > >> > Thank you again, for the insight here. >> > >> > --larry >> > >> > >> > On Sat, Nov 23, 2013 at 10:40 AM, larry mccay <larry.mc...@gmail.com> >> > wrote: >> > >> > > Hi Sebb - >> > > >> > > Thank you for your review and insight! >> > > >> > > We will make these changes immediately and insure that they are >> correct >> > > going forward. >> > > >> > > Do these issues require a new release candidate - or would that only >> be >> > > indicated by a -1? >> > > >> > > thanks, >> > > >> > > --larry >> > > >> > > >> > > On Sat, Nov 23, 2013 at 10:23 AM, sebb <seb...@gmail.com> wrote: >> > > >> > >> On 20 November 2013 16:09, larry mccay <larry.mc...@gmail.com> >> wrote: >> > >> > Hello All, >> > >> > >> > >> > This is a call for a vote on Apache Knox Gateway 0.3.1 incubating. >> > >> > >> > >> > A vote was held on developer mailing list and it passed with 3 >> +1's, >> > >> and 0 >> > >> > -1's or +0's and now >> > >> > requires a vote on general@incubator.apache.org. >> > >> > >> > >> > The [VOTE] thread can be found at: >> > >> > >> > >> >> > >> http://mail-archives.apache.org/mod_mbox/incubator-knox-dev/201311.mbox/%3CCACRbFyjgLrCSahhtWWHK-%3DaeQFM4Oegbe3fQjs-RV2-TAnhdxA%40mail.gmail.com%3E >> > >> > >> > >> > The release candidate is a zip archive of the sources in: >> > >> > https://git-wip-us.apache.org/repos/asf/incubator-knox.git >> > >> > Branch v0.3.1 (git checkout -b v0.3.1) >> > >> > >> > >> > Tag: >> > >> > >> > >> >> > >> https://git-wip-us.apache.org/repos/asf?p=incubator-knox.git;a=tag;h=5a907022dbc2b0a8534de47fe7b8c871c4f075f9 >> > >> >> > >> The NOTICE file is wrong; the first 6 lines should be removed (i.e. >> > >> lines with == and following blank line) >> > >> >> > >> Also, the text should be: >> > >> >> > >> "This product includes software developed at" >> > >> not >> > >> "This product includes software developed by" >> > >> >> > >> > Source archive zip file and signature are available from: >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/knox/knox-incubating-0.3.1/knox-incubating-0.3.1-src.zip >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/knox/knox-incubating-0.3.1/knox-incubating-0.3.1-src.zip.asc >> > >> > >> > >> > Checksums of the source archive: >> > >> > SHA1: 04bb11360f57c0431c30cfb181e3199868fe6053 >> > >> > >> > >> > The KEYS file can be found at: >> > >> > >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/knox/knox-incubating-0.3.1/KEYS >> > >> >> > >> The KEYS file should really be at the top level of the release area, >> > i.e. >> > >> >> > >> https://dist.apache.org/repos/dist/release/incubator/knox/KEYS >> > >> >> > >> > The release changes file can be found at: >> > >> > >> > >> > >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/knox/knox-incubating-0.3.1/CHANGES >> > >> > >> > >> > The release has been signed with key (587C089B): >> > >> > >> > >> >> http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0x82F9C371587C089B >> > >> > >> > >> > Vote will be open for 72 hours. >> > >> > >> > >> > thanks, >> > >> > >> > >> > --larry >> > >> > >> > >> > Larry McCay >> > >> >> > >> --------------------------------------------------------------------- >> > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > >> For additional commands, e-mail: general-h...@incubator.apache.org >> > >> >> > >> >> > > >> > >> >> -- >> CONFIDENTIALITY NOTICE >> NOTICE: This message is intended for the use of the individual or entity >> to >> which it is addressed and may contain information that is confidential, >> privileged and exempt from disclosure under applicable law. If the reader >> of this message is not the intended recipient, you are hereby notified >> that >> any printing, copying, dissemination, distribution, disclosure or >> forwarding of this communication is strictly prohibited. If you have >> received this communication in error, please contact the sender >> immediately >> and delete it from your system. Thank You. >> > >
