+1 (binding)
apart from the jQuery question it looks fine. You might btw be carefull with the samples. If we publish a WAR which contains other libraries, then this might be interpreted as 'distributing' them. In OpenWebBeans, DeltaSpike and MyFaces we don't deploy them any longer in binary form. Just the sources. Users can easily build it themselfs. And most of the times they are only interested in the sample source anyway. LieGrue, strub ----- Original Message ----- > From: Francesco Chicchiriccò <ilgro...@apache.org> > To: general@incubator.apache.org > Cc: > Sent: Monday, August 6, 2012 5:50 PM > Subject: Re: [VOTE] Apache Syncope 1.0.0-incubating > > On 06/08/2012 16:36, Alexei Fedotov wrote: >> Hello Francesco, >> >> Here are few things I have found via manual inspection: >> >> 1. Jquery bundle contains several following strings: "Dual licensed >> under the MIT or GPL Version 2 licenses." >> *) source release LICENSE file does not contain MIT license; >> *) and the file itself does not look like APL licensed; >> *) and it is a part of the source release. >> >> Something should be fixed here, i.e. the files replaced with wget in >> the build script. >> >> 2. ./legal_ext/LICENSE does not have a license for jquery. Does war >> contain jquery? > > Hi Alexei, > I've taken a look at other ASF projects including JQuery (or similar > dual-licensed JS frameworks) and I've opened > https://issues.apache.org/jira/browse/SYNCOPE-181 > We'll fix this ASAP. > >> Don't think these issues are stoppers. > > Cool :-) > What's your vote on the release, then? > > Thanks for your review. > Regards. > >> On Mon, Aug 6, 2012 at 6:07 PM, Mark Struberg <strub...@yahoo.de> > wrote: >>> Hi Francesco, I can check in the evening. >>> >>> LieGrue, >>> strub >>> >>> >>> >>> ----- Original Message ----- >>>> From: Francesco Chicchiriccò <ilgro...@apache.org> >>>> To: general@incubator.apache.org >>>> Cc: >>>> Sent: Monday, August 6, 2012 2:49 PM >>>> Subject: Re: [VOTE] Apache Syncope 1.0.0-incubating >>>> >>>> Hi IPMC members, >>>> we are missing a single vote on this release: anyone interested to > check? >>>> >>>> TIA. >>>> Regards. >>>> >>>> On 03/08/2012 09:58, Francesco Chicchiriccò wrote: >>>>> I've created a 1.0.0-incubating release, with the > following artifacts >>>> up >>>>> for a vote: >>>>> >>>>> SVN source tag (r1367421): >>>>> >>>> > https://svn.apache.org/repos/asf/incubator/syncope/tags/syncope-1.0.0-incubating/ >>>>> List of changes: >>>>> >>>> > https://svn.apache.org/repos/asf/incubator/syncope/tags/syncope-1.0.0-incubating/CHANGES >>>>> Maven staging repo: >>>>> > https://repository.apache.org/content/repositories/orgapachesyncope-100/ >>>>> >>>>> Source release (checksums and signatures are available at the > same >>>>> location): >>>>> >>>> > https://repository.apache.org/content/repositories/orgapachesyncope-100/org/apache/syncope/syncope-root/1.0.0-incubating/syncope-root-1.0.0-incubating-source-release.zip >>>>> Staging site: >>>>> http://incubator.apache.org/syncope/1.0.0-incubating/ >>>>> >>>>> PGP release keys (signed using 273DF287): >>>>> http://www.apache.org/dist/incubator/syncope/KEYS >>>>> >>>>> >>>>> This has been voted through on the > syncope-...@incubator.apache.org >>>>> mailing list [1], >>>>> and now requires a vote on general@incubator.apache.org >>>>> >>>>> Votes already cast (on syncope-dev): >>>>> >>>>> +1 (binding) >>>>> * Francesco Chicchiriccò >>>>> * Massimiliano Perrone >>>>> * Marco Di Sabatino Di Diodoro >>>>> * Emmanuel Lécharny (IPMC member) >>>>> * Simone Tripodi >>>>> * Colm O hEigeartaigh (IPMC member) >>>>> >>>>> +1 (non binding) >>>>> * Denis Signoretto >>>>> >>>>> >>>>> Vote will be open for 72 hours. >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove (and reason why) >>>>> >>>>> Best regards. >>>>> >>>>> [1] >>>>> >>>> > http://syncope-dev.1063484.n5.nabble.com/VOTE-Apache-Syncope-1-0-0-incubating-tp5710173p5710292.html > > -- > Francesco Chicchiriccò > > ASF Member, Apache Cocoon PMC and Apache Syncope PPMC Member > http://people.apache.org/~ilgrosso/ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org