On 24 August 2011 15:13, sebb <seb...@gmail.com> wrote: > On 24 August 2011 00:21, David Lutterkort <lut...@redhat.com> wrote: >> Hi all, >> >> I just uploaded the third release candidate for Deltacloud 0.4.0. The rc is >> available from http://people.apache.org/~lutter/deltacloud/0.4.0/rc3/ >> >> Please vote on the release candidate by Friday, 2011-08-26 15:00 PDT >> > > Where is the KEYS file? > > Where is the SVN tag? >
There are some inconsistencies in the archives. The NOTICE files in both archives mention redhat, yet there is no corresponding mention in the license file. If the archive(s) contain redhat code, then the LICENSE must be updated. If there is no redhat code included, then the NOTICE file must be updated to remove the reference - it's important that the NOTICE file only contains required notices. There are some files without AL headers (and no other license), for example: deltacloud-core-0.4.0/bin/deltacloudd deltacloud-core-0.4.0/config/addresses.xml deltacloud-core-0.4.0/config/condor.yaml deltacloud-core-0.4.0/config/drivers/*.yaml deltacloud-core-0.4.0/lib/deltacloud/base_driver/exceptions.rb deltacloud-core-0.4.0/lib/deltacloud/drivers/mock/data/conv.rb deltacloud-core-0.4.0/lib/deltacloud/drivers/rhevm/rhevm_client.rb deltacloud-core-0.4.0/lib/deltacloud/drivers/vsphere/vsphere_client.rb deltacloud-core-0.4.0/lib/deltacloud/drivers/vsphere/vsphere_filemanager.rb deltacloud-core-0.4.0/lib/sinatra/rack_syslog.rb deltacloud-core-0.4.0/public/javascripts/application.js deltacloud-core-0.4.0/public/stylesheets/new.css There are quite a few .yml files as well; not sure if those allow comments or not Also .css files allow comments, but some of them appear to be autogenerated. The client archive does not have any AL headers in the yml files, but otherwise seems OK. I think the problems in the N&L files and the missing AL headers are blockers. --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org