Thanks, BTW, if adding CDDL license and notice is enough to release, I'd like to do at the moment. Because we're trying to release monthly, and maven pom can be improved next time.
I'm going to upload RC3 again. On Wed, Jul 6, 2011 at 4:52 PM, Dan Haywood <dkhayw...@gmail.com> wrote: > Presumably this means the vote is cancelled, because the ZIP being voted on > hasn't been updated? > > Also... > 1. as I understand it, notices and licenses for 3rd party products should > not go in NOTICE and LICENSE, but should go in DEPENDENCIES. This can be > generated automatically using maven-remote-resources-plugin; missing > information can go in supplemental-models.xml file. The > apache-incubator-disclaimer-resource-bundle (for > maven-remote-resources-plugin) also allows the DEPENDENCIES text to be > customized. > 2. The NOTICE, in particular, should not be modified at all. I know there > are many Apache projects that haven't caught up with this guidance, but this > is what the apache-incubator-disclaimer-resource-bundle specifies. See [1] > 3. I noticed that hama v0.2 was released to maven central repo. Why aren't > the artifacts (including the source zip) uploaded to a staging repo on > repository.apache.org? > 4. the source release seems to contain jar files (in the lib folder). This > doesn't seem right to me. > 5. rather than use javax.servlet from Sun (under CDDL), you could use those > from geronimo specs (under ASL). > > Dan > > [1] http://jira.codehaus.org/browse/MRRESOURCES-32 > > > > On 06/07/2011 02:27, Edward J. Yoon wrote: >> >> Hi, Stefan >> >> Thanks for your review. I've added CDDLv1.0 license and notice. >> >> http://svn.apache.org/repos/asf/incubator/hama/branches/0.3/NOTICE.txt >> http://svn.apache.org/repos/asf/incubator/hama/branches/0.3/LICENSE.txt >> >> Could you please check the files again? >> >> Thanks. >> >> On Wed, Jul 6, 2011 at 6:57 AM, Stefan Seelmann<seelm...@apache.org> >> wrote: >>> >>> Hi Edward, >>> >>> I found an issue which is a blocker IMO: jsp-2.1-6.1.4.jar and >>> jsp-api-2.1-6.1.4.jar from Jetty are included. To my knowlege they are >>> licensed under CDDL*. This is a "Category B" [4] license so either >>> - add the license [1] and the notice excerp [2] to the Hama LICENSE >>> and NOTICE files or >>> - try to use the JSP API and implementation from Tomcat [3] (preferred) >>> >>> Another thing I noticed is that the including >>> hama-examples-0.3.0-incubating.jar is a shaded jar and contains all >>> dependencies. I just wanted to let you know, not sure if that's >>> intended. >>> >>> All other things look good. >>> >>> Kind Regards, >>> Stefan >>> >>> >>> * According to Jetty's notice file [2] the JSP implementation is >>> provided from Glassfish. When looking into the sources >>> >>> (http://repo1.maven.org/maven2/org/mortbay/jetty/jsp-api-2.1/6.1.4/jsp-api-2.1-6.1.4-sources.jar >>> and >>> http://repo1.maven.org/maven2/org/mortbay/jetty/jsp-2.1/6.1.4/jsp-2.1-6.1.4-sources.jar) >>> there are Java files from Sun with CDDL license header. >>> >>> [1] >>> http://svn.codehaus.org/jetty/jetty/tags/jetty-6.1.4/LICENSES/CDDLv1.0.txt >>> [2] >>> http://svn.codehaus.org/jetty/jetty/tags/jetty-6.1.4/LICENSES/NOTICE.txt >>> [3] http://repo1.maven.org/maven2/org/apache/tomcat/jsp-api/6.0.32/ >>> [4] http://apache.org/legal/resolved.html#category-b >>> >>> >>> On Fri, Jul 1, 2011 at 5:36 PM, Edward J. Yoon<edwardy...@apache.org> >>> wrote: >>>> >>>> Hi all, >>>> >>>> The Apache Hama community voted on and approved a proposal to release >>>> Apache Hama 0.3-incubating (RC2). This release contains performance >>>> improvements and new features e.g., maven build, web UI for Hama >>>> cluster, MessageBundle, Dijkstra's Shortest Path and PageRank >>>> examples. >>>> >>>> Please vote on the RC2 for Apache Hama 0.3-Incubating. We've already >>>> received 2 binding IPMC +1 votes. >>>> >>>> Vote thread: >>>> http://markmail.org/thread/qx4u3kjflwe524pf >>>> >>>> Artifact and signatures: >>>> http://people.apache.org/~edwardyoon/dist/0.3.0-RC2/ >>>> >>>> SVN Tag: >>>> https://svn.apache.org/repos/asf/incubator/hama/tags/0.3-RC2/ >>>> >>>> PGP release keys: >>>> https://svn.apache.org/repos/asf/incubator/hama/site/publish/KEYS >>>> >>>> [ ] +1 Release the packages as Apache Hama 0.3-incubating >>>> [ ] -1 Do not release the packages because... >>>> >>>> Thanks. >>>> -- >>>> Best Regards, Edward J. Yoon >>>> @eddieyoon >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>> >>>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> >> >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > -- Best Regards, Edward J. Yoon @eddieyoon --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
