Stefan, thanks for taking the time to review this release candidate. :) See bellow for my comments.
On Tue, Mar 8, 2011 at 3:23 PM, Stefan Bodewig <bode...@apache.org> wrote: > On 2011-03-07, Andrei Savu wrote: > >> Source and binary files: >> http://people.apache.org/~asavu/whirr-0.4.0-incubating-candidate-0 > > The binary contains among other things the Bouncycastle provider so I > think you have to do some extra work (see > <http://www.apache.org/dev/crypto.html>) but I don't see Whirr mentioned > on <http://www.apache.org/licenses/exports/> and can't find any crypto > notice inside the README. Tom will investigate and fix this one. > > RAT flags a few .sh, .css and .html files that are without any license > header. We've already fixed this in trunk. I will backport the patch to the 0.4 branch. > > The binary distribution contains lots of jars that I can't easily match > to the license files in the tarball. What is aws-ec2-1.0-beta-9.jar's > license (likely jcloud's but how would I know)? They all belong to jclouds. We will add the missing license files to the repo. > >> Whirr's KEYS file containing PGP keys we use to sign the release: >> http://svn.apache.org/repos/asf/incubator/whirr/dist/KEYS > > Note the file is different from > <http://www.apache.org/dist/incubator/whirr/KEYS> which doesn't contain > your key. Thanks for pointing this out. I will also update the release instructions on the wiki. > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > We will restart the vote with a new release candidate soon. Cheers, Andrei --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
