On Fri, Aug 21, 2009 at 1:52 PM, sebb<seb...@gmail.com> wrote:
> There is only a combined source/binary archive, which is not standard 
> practise.
> All other projects release a source archive; almost all also release a
> separate binary archive.

FWIW, Apache Wicket has released combined binary/source archives since
its inception. Not something that needs changing.

> The archive does not have a DISCLAIMER file - yes, the disclaimer text
> is in README, but the general practise is for a separate file.

DISCLAIMER should be next to LICENSE, NOTICE and README. Remember to
remove upon graduation :-)

> The NOTICE file is incorrect. The date is 2008, and the second
> paragraph must be:
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
>
> i.e. switch the 2nd and 3rd paragraphs

Should be fixed.

> Minor points:
>
> It would be useful to include compiler source and target versions as
> headers in the jar manifests (the manifests are otherwise good)

Shouldn't maven do this already? [1]

Martijn

[1] http://maven.apache.org/shared/maven-archiver/examples/manifest.html

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to