Hi, Kevan,

first of all, thanks for your observations.

On Wed, Mar 18, 2009 at 12:35 PM, Kevan Miller <kevan.mil...@gmail.com> wrote:

> An pointer to the svn location for your proposed release would be helpful. I
> choose
> http://svn.apache.org/repos/asf/incubator/rat/main/tags/apache-rat-project-0.6/ for
> the following review.

The location you choosed is right. I'll keep that in mind for the next approach.


> The NOTICE file does not contain a copyright statement. See
> http://www.apache.org/legal/src-headers.html#notice

I am not sure, whether I do completely understand, because you are not
mentioning the exact jar file. After checking, my impression is that
the jar files in apache-rat-core, apache-rat-plugins, and
apache-rat-tasks are okay. The jar files in apache-rat, however,
aren't. Could you confirm this, please?


> apache-rat-core/src/main/java/org/apache/rat/analysis/license/W3CDocLicense.java
> contains an old-style apache src license header

Fixed.



> I was not able to build because of a build dependency problem:

[...]

>    mvn install:install-file -DgroupId=org.apache.rat
> -DartifactId=apache-rat-plugin -Dversion=0.6 -Dpackaging=maven-plugin

Understandable. If there isn't yet a release of the plugin, it can't
be used to check itself. I have disabled this use of the plugin.


Thanks,

Jochen


-- 
I have always wished for my computer to be as easy to use as my
telephone; my wish has come true because I can no longer figure out
how to use my telephone.

    -- (Bjarne Stroustrup,
http://www.research.att.com/~bs/bs_faq.html#really-say-that
       My guess: Nokia E50)

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to