Hm, I thought I was subscribed to private-click ... but then again, that
is gene...@incubator.

- Builds for me on JDK 1.6.0_12 on i386 Linux.

- I vote +0 for this release. Reasoning: 

-- It is not obvious to me how to turn off GPL dependencies like
Hibernate. The "get-deps" download downloads all dependencies without
discriminating between Category A  and Category X dependencies (see
http://www.apache.org/legal/resolved.html). 

If you delete the hibernate jar from the libs folder, then ant build-all
no longer works. 

What I actually would like to see in subsequent releases is that Click
(like e.g. Velocity does) dynamically finds out whether a given
dependency is present or not and build the corresponding interface
classes or not. As the rest of the build is very diligent in making sure
that no actual GPL or LGPL classes come into the final build artifacts,
I think for this release, the current status quo is acceptable.

-- rat report looks good (there are a bunch of XML files like
cayenne.xml and cayenneMap.xml) except for the ConcurrentReaderHashMap
file, which contains a "Copyright 1997 Sun Microsystems" Header. Also,
I'd like to have concrete "this is licensed under Apache License /
BSD-style license / MIT license" comments in NOTICE.txt.

You are definitely in a grey area with the ConcurrentReaderHashMap;
please run this by legal before the next release (or if you did, add
clear comments to NOTICE.txt).

So all in all, this is a +0, not a +1.

        Ciao
                Henning 



On Tue, 2009-02-10 at 08:35 +1100, Malcolm Edgar wrote:
> fyi :)
> 
> ---------- Forwarded message ----------
> From: Andrus Adamchik <and...@objectstyle.org>
> Date: Tue, Feb 10, 2009 at 2:49 AM
> Subject: Re: [VOTE] Approve the 2.0.1 release of Apache Click
> To: general@incubator.apache.org
> 
> 
> Anybody else from the Incubator PMC can check the release? Henning?
> Will?
> 
> Thanks,
> Andrus
> 
> 
> 
> On Feb 3, 2009, at 10:10 PM, Bob Schellink wrote:
> 
>         Hi all,
>         
>         The Click community has approved the first release of Apache
>         Click.
>         All IP issues have been resolved and incompatible license
>         dependencies replaced.
>         
>         We would now like to request the approval of the Incubator PMC
>         for this release.
>         
>         The vote on the click-dev mailing list resulted in 5 +1 votes
>         (4 binding) and no other votes:
>         
>         Andrus Adamchik +1
>         Bob Schellink   +1
>         Naoki Takezoe   +1
>         Malcolm Edgar   +1
>         Ricardo Lecheta +1
>         
>         Vote thread: http://click.markmail.org/search/#query:+page:1
>         +mid:3t5lfsusnizffj4t+state:results
>         
>         Distribution can be found here:
>         
>         http://people.apache.org/~sabob/click/click/2.0.1/dist/
>         
>         Maven artifacts can be found here:
>         
>         http://people.apache.org/~sabob/click/click/2.0.1/maven2/
>         
>         
>         Project home: http://incubator.apache.org/click/
>         Incubation status:
>         http://incubator.apache.org/projects/click.html
>         
>         Thanks
>         
>         Bob
>         
>         ---------------------------------------------------------------------
>         To unsubscribe, e-mail:
>         general-unsubscr...@incubator.apache.org
>         For additional commands, e-mail:
>         general-h...@incubator.apache.org
>         
>         
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to