Hi Robert, I'm one of the OFBiz committers and I'd like to thank you for your great scrutiny: this is very helpful and we are currently working to fix all the issues that you (and others in this list) have found.
Please see my comments inline: robert burrell donkin wrote: > > ***IMPORTANT*** > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/rmi/socket/zip/CompressionClientSocketFactory.java, > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/rmi/socket/zip/CompressionInputStream.java > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/rmi/socket/zip/CompressionOutputStream.java, > framework/service/src/org/ofbiz/service/rmi/socket/zip/CompressionServerSocketFactory.java, > framework/service/src/org/ofbiz/service/rmi/socket/zip/CompressionSocket.java, > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/rmi/socket/zip/CompressionServerSocket.java > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/service/src/org/ofbiz/service/rmi/socket/zip/CompressionConstants.java > > do not appear to be licensed under an OSI compliant license. IMO the > terms are badly drafted and discriminate against the profession or > vocation of comedian (no laughing matter ;-) basically anyone using > the software must agree not to use the software to make fun of sun. > but IANAL and this needs to be raised on legal-discuss. > We are currently working on this. > > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/content/webapp/content/WEB-INF/pagedefs/cms/CMSSiteFind.xml > > is a bit of a mystery and seems to be lacking source > The file was not used and has been removed in rev. 450796 > no license headers (check whether they are apache source) > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/content/webapp/content/images/agincutil.js > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/content/webapp/content/images/composite.js The above two files were not used and have been removed in rev. 450798 (by David Jones) > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/product/webapp/facility/facility/batchPrintMarkAsAccepted.ftl Added ASL2.0 license in rev 450812 > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/common/data/GeoData_ES.xml Added ASL2.0 license in rev 450795 > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/content/webapp/content/images/contentForum.css > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/ecommain.css > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/maincss.css > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/tabstyles.css Added ASL2.0 license to the four files above in rev 450798 (by David Jones) > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/webtools/webapp/webtools/UomReport.xml Added ASL2.0 license in rev 450794 > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/webtools/webapp/webtools/includes/datepicker.js > The file was not used and has been removed in rev. 450821 > > i'm worried about > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/pos/dtd/jcl.dtd. > > DTD are a a PITA but it's a document and we need permission to > distribute. > We are currently working on this. > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/product/config/ProductEntityLabels_fr.properties > > is licensed under Eclipse Public License v1.0. the draft third part > licensing policy allows this in only binary form due to a reciprocity > clause in the license. i'm a little worried by the fact that this is > the only localisation file which is not ASL'd. > Added ASL2.0 license in rev 450793 (after I have verified from the svn log that the file has been contributed by a person with ICLA on file and thru the Apache Jira server). > > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/appserver/templates/weblogic81/startOFBizServer.cmd > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/appserver/templates/weblogic81/startOFBizServer.sh > > lack license files and appear to be similar to standard weblogic > startup scripts. this could be perfectly innocent (there are only a > few ways to start the server) and hopefully not an unfortunate > unlicensed derivative work... > We are currently working on this. > ofbiz/framework/data/derby/ in the distribution contains some logs and > other bits and bats which aren't in subversion and i suspect didn't > really want to get released. same goes for ofbiz/framework/logs/ > This happens because this is a binary release that can be run out of the box using a pre-built derby db. > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/calendar.html > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/calendar1.js > > terms probably needs to be noted in LICENSE > > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/calendarTable.css, > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/combobox.js, > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/fieldlookup.js > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/images/webapp/images/calendarstyles.css > > appear to be associated with above but lack license headers. need to > check the right license. > We are currently working on this. > http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/framework/workflow/dtd/xpdl.dtd > > has no license header but perhaps is part of a specification? We are currently working on this. Again, thanks, for your great feedback! Jacopo --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
