Thanks Roni, I appreciate the review! Comments below:
> 1. In table 1 the allocation for Nil And Max UUID is specified but not in > Table 2 (version 0 and 15) NIL and MAX are not part of the variant space 10x described in that table. They do not have a version table since the versioning of those other UUID variant is out of scope for this doc (in fact some of those spaces don’t' even use a construct of a version). NIL was defined by RFC4122 and the group decided to also reserve the inverse MAX UUID in the updated doc as to complete that pair. I hope that makes sense. > 2. In section 5 some of the sun section when the describing the ver field > mention the value while some do not Yes, something we caught that and are cleaning up in https://github.com/ietf-wg-uuidrev/rfc4122bis/pull/128 With this PR all of the bit layout field definitions will include the same items. Value, bit occupancy, octets, Etc. > 3. In section 4 first paragraph “ the variant bits in conjunction with the > version bits described in the next sections in determine finer structure.” > the second “in” before “determine” is typo? Correct, DNSDIR review caught that and I have fixed it in https://github.com/ietf-wg-uuidrev/rfc4122bis/issues/122 Thanks, -----Original Message----- From: Roni Even via Datatracker <nore...@ietf.org> Sent: Wednesday, August 2, 2023 2:21 PM To: gen-art@ietf.org Cc: draft-ietf-uuidrev-rfc4122bis....@ietf.org; last-c...@ietf.org; uuid...@ietf.org Subject: Genart last call review of draft-ietf-uuidrev-rfc4122bis-08 Reviewer: Roni Even Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-uuidrev-rfc4122bis-?? Reviewer: Roni Even Review Date: 2023-08-02 IETF LC End Date: 2023-08-08 IESG Telechat date: Not scheduled for a telechat Summary: The document is ready for publication as standard track RFC with nits Major issues: Minor issues: Nits/editorial comments: 1. In table 1 the allocation for Nil And Max UUID is specified but not in Table 2 (version 0 and 15) 2. In section 5 some of the sun section when the describing the ver field mention the value while some do not 3. In section 4 first paragraph “ the variant bits in conjunction with the version bits described in the next sections in determine finer structure.” the second “in” before “determine” is typo?
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www.ietf.org/mailman/listinfo/gen-art
