Responses in-line - with extra removed for clarity. -------- 73, Adam T. Wiethuechter Software Engineer; AX Enterprize, LLC
________________________________ On 10/13/2022 3:06 PM, Adam Wiethuechter wrote: From: Matt Joras via Datatracker <nore...@ietf.org><mailto:nore...@ietf.org> Reviewer: Matt Joras Review result: Ready with Nits DRIP Specific Authentication Methods, carried in ASTM Authentication Messages (Message Type 0x2) are defined herein. These methods, when properly used, enable a high level of trust in that the content of other ASTM Messages was generated by their claimed registered source. The last sentence here is a bit confusing, consider rewording "enable a high level of trust in that the". <atw> Looks like it was a bad copy paste during a recent reworking of that paragraph. Switched to: "enable a high level of trust in the content of other ASTM Messages that was generated by their claimed registered source" </atw> Actually, we want to make clear that we are not encouraging trust in the message content itself, only authenticating that the content indeed came from the claimed source. E.g. "enable a high level of trust in that the" => "enable a high level of trust that the" Simple removing the word "in" from the original sentence should fix it? <atw> I will change, after talking with Stu directly, to his suggestion as my fix was still a broken sentence. </atw> 4.3.1. Message Count When decoding a DRIP Wrapper on a receiver, the number of messages wrapped can be determined by checking the length between the UA DET and the VNB Timestamp by UA is a multiple of 25-bytes. Consider rewording. "checking" here sort of implies that an invariant is being checked, rather than the number of messages being calculated (i.e. integral division by 25). <atw> Rewording "checking" to "calculating". </atw> We have conflated 2 issues here. (1) We want to sanity check that the Wrapper is of a valid length, which must be a multiple of 25; if not, something is wrong and we probably want to discard the message and complain. (2) We need to know how many messages are in the Wrapper. We can calculate that by dividing the length by 25. So, this could be pseudo-coded as: wrapperLengthValid := ((wrapperLength MOD 25) == 0); wrappedMsgCount := wrapperLength DIV 25; So we are _both_ "checking" and "calculating". ;-) Wording to be smithed. <atw> In an attempt to make this a bit better I have included these pseudo-code snippets in the draft and renamed the sections accordingly. This is being done to both Wrapper and Manifest. Please check out -26 coming out in the hour. </atw> -- ----------------------------------------- Stuart W. Card, PhD, Principal Engineer AX Enterprize, LLC www.axenterprize.com<http://www.axenterprize.com> 4947 Commercial Drive, Yorkville NY 13495 592 Hangar Road, Rome NY 13441
_______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www.ietf.org/mailman/listinfo/gen-art
