Hi Rizwana, It could very well be that you’ve hit a bug. I’d suggest to post a review on the reviewboard to make it more clear what changes need to be done. If you’re not familiar with the process have a look at http://www.gem5.org/Commit_Access. The easiest is to use the reviewboard mercurial plugin.
I look forward to see the patch. Thanks, Andreas From: Rizwana Begum via gem5-users <gem5-users@gem5.org<mailto:gem5-users@gem5.org>> Reply-To: Rizwana Begum <rizwana....@gmail.com<mailto:rizwana....@gmail.com>>, gem5 users mailing list <gem5-users@gem5.org<mailto:gem5-users@gem5.org>> Date: Wednesday, 21 January 2015 16:24 To: gem5 users mailing list <gem5-users@gem5.org<mailto:gem5-users@gem5.org>> Subject: [gem5-users] DRAM controller write requests merge Hello Users, I am trying to understanding write packets queuing in DRAM controller model. I am looking at 'addToWriteQueue' function. From my understanding so far, it merges write requests across burst boundaries. Looking at following if statement: if ((addr + size) >= (*w)->addr && ((*w)->addr + (*w)->size - addr) <= burstSize) { // the new one is just before or partially // overlapping with the existing one, and together // they fit within a burst .... .... .... } Merging here may make the write request go across burst boundary. Size computation in the beginning of the for loop of this function suggests that packets are split at burst boundaries. For example, if the packet addr is 16, burst size is 32 bytes and packet request size is 25 bytes (all in decimal for ease), then 2 write bursts should be added to the queue: 16-31, 32-40. However, while merging, lets say if there existed a packet already in write queue from 32-40, then a write from 16-40 is added to the queue which is across burst boundary. is that physically possible? Shouldn't there be two write requests in the queue:16-31, 32-40 instead of one single merged request? Thank you, -Rizwana -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
_______________________________________________ gem5-users mailing list gem5-users@gem5.org http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users
