Hi all,

We have got a fix, but for now I will commit a change that turns it into a 
warning instead of a fatal. I don't want Amin to have to rebase his patch 
(again) :-)

Andreas

From: Amin Farmahini <amin...@gmail.com<mailto:amin...@gmail.com>>
Reply-To: gem5 users mailing list 
<gem5-users@gem5.org<mailto:gem5-users@gem5.org>>
Date: Monday, July 29, 2013 5:44 AM
To: gem5 users mailing list <gem5-users@gem5.org<mailto:gem5-users@gem5.org>>
Subject: Re: [gem5-users] Is it right sanity check in simple_dram.cc??

I have got that panic error a few times so far when the running application is 
memory-intensive with low temporal locality.
I could not figure out why this panics, but I don't think they consider only 
first and last activations. A list of past X activations is kept, where X is 
the maximum number of allowed activations in a rolling window. The size of 
actTicks is always X.
Anyway, I agree with you that this should be fixed, but if I understand you 
right, your solution does not work.

Thanks,
Amin



On Sun, Jul 28, 2013 at 10:24 PM, ?????? 
<limjong...@gmail.com<mailto:limjong...@gmail.com>> wrote:
I'm using gem5 to simulate multi-core (or multi-cpu) environment, but I got 
error about dram activate sanity check.
There is recordActivate (Tick act_tick) module In simple_dram.cc. In that 
module, gem5 did sanity check.
It is true that in same DRAM device, it can't activate X times in tXAW. But 
gem5 do not care the number of activate operations, only consider first and 
last activation time.
I think, it need to check the number of activation operations too. Like this,

void
SimpleDRAM::recordActivate(Tick act_tick)
{
   ...
 // sanity check
   if ( actTick.size() == activationLimit-1) {
         if (actTicks.back() && (act_tick - actTicks.back()) < tXAW) {
            panic("Got %d activates in window %d (%d - %d) which is smaller "
             "than %d\n", activationLimit, act_tick - actTicks.back(),
            act_tick, actTicks.back(), tXAW);
      }
   }
   ...
}

Please help me.


_______________________________________________
gem5-users mailing list
gem5-users@gem5.org<mailto:gem5-users@gem5.org>
http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users


-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
_______________________________________________
gem5-users mailing list
gem5-users@gem5.org
http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users

Reply via email to