Hi Samuel, 

I think you're right. Sorry about that. 

Thanks, 

Ali


On 29.05.2012 11:38, Samuel Hitz wrote: 

> Hi there, 
> I'm working
with gem5 for several months now, however I only lately updated to the
latest release and there was something added, which doesn't make sense
to me (and breaks my code). 
> In 'src/dev/arm/gic.cc' function
'readDistributor' you added assertions (line 196 and 202) to check array
bounds for the interrupt priority array, however those are wrong in my
opinion. Here is the assertion you added 
> assert((int_num + 3) <
(SGI_MAX + PPI_MAX)); 
> where SGI_MAX and PPI_MAX are both 16 (which is
correct), but this way you allow only interrupts up to 28. I assume what
you meant is something like 
> assert((int_num + 3) < (INT_LINES_MAX));

> Could someone fix this issue or tell me why this should be correct?

> Best, 
> Samuel

 
_______________________________________________
gem5-users mailing list
gem5-users@gem5.org
http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users

Reply via email to