Attention is currently required from: Richard Cooper.
Hello Richard Cooper,
I'd like you to do a code review.
Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/70730?usp=email
to review the following change.
Change subject: arch-arm: Add support for Arm SVE Integer Matrix
instructions.
......................................................................
arch-arm: Add support for Arm SVE Integer Matrix instructions.
Add support for the Arm SVE Integer Matrix Multiply-Accumulate
(SMMLA, USMMLA, UMMLA) instructions. Because the associated SUDOT and
USDOT instructions have not yet been implemented, the SVE Feature ID
register 0 (ID_AA64ZFR0_EL1) has not yet been updated to indicate
support for SVE Int8 matrix multiplication instructions at this time.
For more information please refer to the "ARM Architecture Reference
Manual Supplement - The Scalable Vector Extension (SVE), for ARMv8-A"
(https://developer.arm.com/architectures/cpu-architecture/a-profile/
docs/arm-architecture-reference-manual-supplement-armv8-a)
Additional Contributors: Giacomo Travaglini
Change-Id: Ia50e28fae03634cbe04b42a9900bab65a604817f
Reviewed-by: Richard Cooper <richard.coo...@arm.com>
---
M src/arch/arm/isa/formats/sve_2nd_level.isa
M src/arch/arm/isa/formats/sve_top_level.isa
M src/arch/arm/isa/insts/sve.isa
3 files changed, 72 insertions(+), 0 deletions(-)
diff --git a/src/arch/arm/isa/formats/sve_2nd_level.isa
b/src/arch/arm/isa/formats/sve_2nd_level.isa
index 6add341..e0ab5f9 100644
--- a/src/arch/arm/isa/formats/sve_2nd_level.isa
+++ b/src/arch/arm/isa/formats/sve_2nd_level.isa
@@ -246,6 +246,33 @@
} // decodeSveIntMulAdd
StaticInstPtr
+ decodeSveIntMatMulAdd(ExtMachInst machInst)
+ {
+ RegIndex zda = (RegIndex) (uint8_t) bits(machInst, 4, 0);
+ RegIndex zn = (RegIndex) (uint8_t) bits(machInst, 9, 5);
+ RegIndex zm = (RegIndex) (uint8_t) bits(machInst, 20, 16);
+
+ uint8_t uns = bits(machInst, 23, 22);
+
+ switch (uns) {
+ case 0x0:
+ return new SveSmmla<int32_t, int8_t, int8_t>(
+ machInst, zda, zn, zm);
+ case 0x2:
+ return new SveUsmmla<int32_t, uint8_t, int8_t>(
+ machInst, zda, zn, zm);
+ case 0x3:
+ return new SveUmmla<uint32_t, uint8_t, uint8_t>(
+ machInst, zda, zn, zm);
+ case 0x1:
+ default:
+ return new Unknown64(machInst);
+ }
+
+ return new Unknown64(machInst);
+ } // decodeSveIntMatMulAdd
+
+ StaticInstPtr
decodeSveShiftByImmPred0(ExtMachInst machInst)
{
RegIndex zdn = (RegIndex) (uint8_t) bits(machInst, 4, 0);
@@ -3763,5 +3790,21 @@
return new Unknown64(machInst);
} // decodeSveMemStore
+ StaticInstPtr
+ decodeSveMisc(ExtMachInst machInst) {
+ switch(bits(machInst, 13, 10)) {
+ case 0b0110: {
+ return decodeSveIntMatMulAdd(machInst);
+ break;
+ }
+ default: {
+ return new Unknown64(machInst);
+ break;
+ }
+ }
+ return new Unknown64(machInst);
+ } // decodeSveMisc
+
+
} // namespace Aarch64
}};
diff --git a/src/arch/arm/isa/formats/sve_top_level.isa
b/src/arch/arm/isa/formats/sve_top_level.isa
index 1f3b463..0699637 100644
--- a/src/arch/arm/isa/formats/sve_top_level.isa
+++ b/src/arch/arm/isa/formats/sve_top_level.isa
@@ -44,6 +44,7 @@
StaticInstPtr decodeSveShiftByImmPred(ExtMachInst machInst);
StaticInstPtr decodeSveIntArithUnaryPred(ExtMachInst machInst);
StaticInstPtr decodeSveIntMulAdd(ExtMachInst machInst);
+ StaticInstPtr decodeSveIntMatMulAdd(ExtMachInst machInst);
StaticInstPtr decodeSveIntArithUnpred(ExtMachInst machInst);
StaticInstPtr decodeSveIntLogUnpred(ExtMachInst machInst);
StaticInstPtr decodeSveIndexGen(ExtMachInst machInst);
@@ -93,6 +94,8 @@
StaticInstPtr decodeSveMemContigLoad(ExtMachInst machInst);
StaticInstPtr decodeSveMemGather64(ExtMachInst machInst);
StaticInstPtr decodeSveMemStore(ExtMachInst machInst);
+
+ StaticInstPtr decodeSveMisc(ExtMachInst machInst);
}
}};
@@ -103,6 +106,14 @@
StaticInstPtr
decodeSveInt(ExtMachInst machInst)
{
+ if (bits(machInst, 31, 29) == 0b010) {
+ if (bits(machInst, 24) == 0b1 &&
+ bits(machInst, 21) == 0b0 &&
+ bits(machInst, 15, 14)==0b10) {
+ return decodeSveMisc(machInst);
+ }
+ }
+
uint8_t b_29_24_21 = (bits(machInst, 29) << 2) |
(bits(machInst, 24) << 1) |
bits(machInst, 21);
diff --git a/src/arch/arm/isa/insts/sve.isa b/src/arch/arm/isa/insts/sve.isa
index 30dbeba..f7bf8a3 100644
--- a/src/arch/arm/isa/insts/sve.isa
+++ b/src/arch/arm/isa/insts/sve.isa
@@ -4192,6 +4192,24 @@
# MLS
mlsCode = 'destElem -= srcElem1 * srcElem2;'
sveTerInst('mls', 'Mls', 'SimdMultAccOp', signedTypes, mlsCode)
+
+ mmlaCode = ('destElem += srcElemA * srcElemB')
+ # SMMLA (vectors)
+ sveMatMulInst('smmla', 'Smmla', 'SimdMultAccOp',
+ (('int32_t', 'int8_t', 'int8_t'),),
+ numDestRows=2, numDestCols=2, K=8,
+ elt_mul_op=mmlaCode)
+ # USMMLA (vectors)
+ sveMatMulInst('usmmla', 'Usmmla', 'SimdMultAccOp',
+ (('int32_t', 'uint8_t', 'int8_t'),),
+ numDestRows=2, numDestCols=2, K=8,
+ elt_mul_op=mmlaCode)
+ # UMMLA (vectors)
+ sveMatMulInst('ummla', 'Ummla', 'SimdMultAccOp',
+ (('uint32_t', 'uint8_t', 'uint8_t'),),
+ numDestRows=2, numDestCols=2, K=8,
+ elt_mul_op=mmlaCode)
+
# MOVPRFX (predicated)
movCode = 'destElem = srcElem1;'
sveUnaryInst('movprfx', 'MovprfxPredM', 'SimdMiscOp', unsignedTypes,
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70730?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ia50e28fae03634cbe04b42a9900bab65a604817f
Gerrit-Change-Number: 70730
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Richard Cooper <richard.coo...@arm.com>
Gerrit-Attention: Richard Cooper <richard.coo...@arm.com>
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
