Attention is currently required from: Richard Cooper.
Hello Richard Cooper,
I'd like you to do a code review.
Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/70560?usp=email
to review the following change.
Change subject: arch-arm: Implement RAZ/WI with raz specifier
......................................................................
arch-arm: Implement RAZ/WI with raz specifier
Change-Id: I195f042fbeb10c0ca1f9095a0d26e6c213496ee5
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Richard Cooper <richard.coo...@arm.com>
---
M src/arch/arm/isa.cc
M src/arch/arm/regs/misc.cc
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/arch/arm/isa.cc b/src/arch/arm/isa.cc
index 14349b1..7df8978 100644
--- a/src/arch/arm/isa.cc
+++ b/src/arch/arm/isa.cc
@@ -470,12 +470,6 @@
return readMiscRegNoEffect(idx);
}
break;
- case MISCREG_JOSCR: // Jazelle trivial implementation, RAZ/WI
- case MISCREG_JMCR: // Jazelle trivial implementation, RAZ/WI
- case MISCREG_JIDR: // Jazelle trivial implementation, RAZ/WI
- case MISCREG_AIDR: // AUX ID set to 0
- case MISCREG_TCMTR: // No TCM's
- return 0;
case MISCREG_CLIDR:
warn_once("The clidr register always reports 0 caches.\n");
diff --git a/src/arch/arm/regs/misc.cc b/src/arch/arm/regs/misc.cc
index 960c2be..6c5a9dd 100644
--- a/src/arch/arm/regs/misc.cc
+++ b/src/arch/arm/regs/misc.cc
@@ -2505,12 +2505,15 @@
.unimplemented()
.allPrivileges();
InitReg(MISCREG_JIDR)
+ .raz() // Jazelle trivial implementation, RAZ/WI
.allPrivileges();
InitReg(MISCREG_TEEHBR)
.allPrivileges();
InitReg(MISCREG_JOSCR)
+ .raz() // Jazelle trivial implementation, RAZ/WI
.allPrivileges();
InitReg(MISCREG_JMCR)
+ .raz() // Jazelle trivial implementation, RAZ/WI
.allPrivileges();
// AArch32 CP15 registers
@@ -2548,6 +2551,7 @@
.unserialize(0)
.allPrivileges().exceptUserMode().writes(0);
InitReg(MISCREG_TCMTR)
+ .raz() // No TCM's
.allPrivileges().exceptUserMode().writes(0);
InitReg(MISCREG_TLBTR)
.reset(1) // Separate Instruction and Data TLBs
@@ -2646,6 +2650,7 @@
InitReg(MISCREG_CLIDR)
.allPrivileges().exceptUserMode().writes(0);
InitReg(MISCREG_AIDR)
+ .raz() // AUX ID set to 0
.allPrivileges().exceptUserMode().writes(0);
InitReg(MISCREG_CSSELR)
.banked();
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/70560?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I195f042fbeb10c0ca1f9095a0d26e6c213496ee5
Gerrit-Change-Number: 70560
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Richard Cooper <richard.coo...@arm.com>
Gerrit-Attention: Richard Cooper <richard.coo...@arm.com>
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
