Earl Ou has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67531?usp=email )
Change subject: mem: use default backdoor behavior for thread_bridge
......................................................................
mem: use default backdoor behavior for thread_bridge
The original backdoor implementation is incorrect. We use simply
fallback to default (disable backdoor) as backdoor across threads is not
thread-safe in most of cases.
Change-Id: Ia39be0dda4f16917cc3565eb5b012270e6d7697a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67531
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Yu-hsin Wang <yuhsi...@google.com>
---
M src/mem/thread_bridge.cc
M src/mem/thread_bridge.hh
2 files changed, 17 insertions(+), 18 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
Yu-hsin Wang: Looks good to me, approved
diff --git a/src/mem/thread_bridge.cc b/src/mem/thread_bridge.cc
index 0090e42..5af2a59 100644
--- a/src/mem/thread_bridge.cc
+++ b/src/mem/thread_bridge.cc
@@ -64,12 +64,6 @@
// AtomicResponseProtocol
Tick
-ThreadBridge::IncomingPort::recvAtomicBackdoor(PacketPtr pkt,
- MemBackdoorPtr &backdoor)
-{
- panic("ThreadBridge only supports atomic/functional access.");
-}
-Tick
ThreadBridge::IncomingPort::recvAtomic(PacketPtr pkt)
{
EventQueue::ScopedMigration migrate(device_.eventQueue());
@@ -84,14 +78,6 @@
device_.out_port_.sendFunctional(pkt);
}
-void
-ThreadBridge::IncomingPort::recvMemBackdoorReq(const MemBackdoorReq &req,
- MemBackdoorPtr &backdoor)
-{
- EventQueue::ScopedMigration migrate(device_.eventQueue());
- device_.out_port_.sendMemBackdoorReq(req, backdoor);
-}
-
ThreadBridge::OutgoingPort::OutgoingPort(const std::string &name,
ThreadBridge &device)
: RequestPort(name), device_(device)
diff --git a/src/mem/thread_bridge.hh b/src/mem/thread_bridge.hh
index 92cb078..8a253fd 100644
--- a/src/mem/thread_bridge.hh
+++ b/src/mem/thread_bridge.hh
@@ -55,14 +55,10 @@
void recvRespRetry() override;
// AtomicResponseProtocol
- Tick recvAtomicBackdoor(PacketPtr pkt,
- MemBackdoorPtr &backdoor) override;
Tick recvAtomic(PacketPtr pkt) override;
// FunctionalResponseProtocol
void recvFunctional(PacketPtr pkt) override;
- void recvMemBackdoorReq(const MemBackdoorReq &req,
- MemBackdoorPtr &backdoor) override;
private:
ThreadBridge &device_;
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67531?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ia39be0dda4f16917cc3565eb5b012270e6d7697a
Gerrit-Change-Number: 67531
Gerrit-PatchSet: 5
Gerrit-Owner: Earl Ou <shunhsin...@google.com>
Gerrit-Reviewer: Earl Ou <shunhsin...@google.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-Reviewer: Yu-hsin Wang <yuhsi...@google.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
