Gabriel B. has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67431?usp=email )
Change subject: scons: Link tcmalloc_minimal by default instead of tcmalloc
......................................................................
scons: Link tcmalloc_minimal by default instead of tcmalloc
tcmalloc triggers asan while tcmalloc_minimal does not. The feature
difference is not significant for regular gem5 use.
Jira issue: https://gem5.atlassian.net/browse/GEM5-1312
Change-Id: I410a26d2ecdf422c456d44276d9e7ec60582b8cc
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67431
Maintainer: Bobby Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Bobby Bruce <bbr...@ucdavis.edu>
---
M SConstruct
1 file changed, 20 insertions(+), 2 deletions(-)
Approvals:
kokoro: Regressions pass
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
diff --git a/SConstruct b/SConstruct
index 2e525a3..6abbb51 100755
--- a/SConstruct
+++ b/SConstruct
@@ -609,9 +609,9 @@
if not GetOption('without_tcmalloc'):
with gem5_scons.Configure(env) as conf:
- if conf.CheckLib('tcmalloc'):
+ if conf.CheckLib('tcmalloc_minimal'):
conf.env.Append(CCFLAGS=conf.env['TCMALLOC_CCFLAGS'])
- elif conf.CheckLib('tcmalloc_minimal'):
+ elif conf.CheckLib('tcmalloc'):
conf.env.Append(CCFLAGS=conf.env['TCMALLOC_CCFLAGS'])
else:
warning("You can get a 12% performance improvement by "
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67431?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I410a26d2ecdf422c456d44276d9e7ec60582b8cc
Gerrit-Change-Number: 67431
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriel B. <gabriel.bus...@arteris.com>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Gabriel B. <gabriel.bus...@arteris.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
