Majid Jalili has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/56265 )

Change subject: mem-cache: adding round-robin aribitration to multiprefetchers
......................................................................

mem-cache: adding round-robin aribitration to multiprefetchers

To find a candidate in cache base.cc, function getPacket
is called. In case of multi-prefetchers, we alyways start
from the first prefetcher. Given the default value for "latency"
is 1, there is always a candidate ready for prefech by prefetcher 0.
Hence, we need an arbitration mechansim to cycle through
all prefechers

JIRA Ticket: https://gem5.atlassian.net/browse/GEM5-1169

Change-Id: I1c6a267b2bf71764559a080371c1d7f8be95ac71
---
M src/mem/cache/prefetch/multi.cc
M src/mem/cache/prefetch/multi.hh
2 files changed, 24 insertions(+), 1 deletion(-)



diff --git a/src/mem/cache/prefetch/multi.cc b/src/mem/cache/prefetch/multi.cc
index 230db50..aebdc82 100644
--- a/src/mem/cache/prefetch/multi.cc
+++ b/src/mem/cache/prefetch/multi.cc
@@ -73,14 +73,19 @@
 PacketPtr
 Multi::getPacket()
 {
+    uint8_t chosen_pf = 0;
     for (auto pf : prefetchers) {
         if (pf->nextPrefetchReadyTime() <= curTick()) {
             PacketPtr pkt = pf->getPacket();
panic_if(!pkt, "Prefetcher is ready but didn't return a packet.");
             prefetchStats.pfIssued++;
             issuedPrefetches++;
+            std::rotate(prefetchers.begin(),
+                        prefetchers.begin() + chosen_pf + 1,
+                        prefetchers.end());
             return pkt;
         }
+        chosen_pf +=1;
     }

     return nullptr;
diff --git a/src/mem/cache/prefetch/multi.hh b/src/mem/cache/prefetch/multi.hh
index 037d23e..64d0963 100644
--- a/src/mem/cache/prefetch/multi.hh
+++ b/src/mem/cache/prefetch/multi.hh
@@ -70,7 +70,7 @@

   protected:
     /** List of sub-prefetchers ordered by priority. */
-    std::list<Base*> prefetchers;
+    std::vector<Base*> prefetchers;
 };

 } // namespace prefetch

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/56265
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I1c6a267b2bf71764559a080371c1d7f8be95ac71
Gerrit-Change-Number: 56265
Gerrit-PatchSet: 1
Gerrit-Owner: Majid Jalili <majid0jal...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to