Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/54623 )
Change subject: util-docker: Update how rocBLAS is built in gcn-gpu
Dockerfile
......................................................................
util-docker: Update how rocBLAS is built in gcn-gpu Dockerfile
rocBLAS builds for all targets by default, but it requires we set the
HCC_AMDGPU_TARGET env variable to all the targets we want to build for.
This change explicitly sets all the gfx versions we intend to support in
gem5, and removes the extraneous "-a all" from the install command.
Additionally, doing this allowed for DNNMark to run on gfx902.
Change-Id: Id1a00433beaa23f6935c12073d5bddc38431886b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/54623
Reviewed-by: Matt Sinclair <[email protected]>
Maintainer: Matt Sinclair <[email protected]>
Reviewed-by: Matthew Poremba <[email protected]>
Tested-by: kokoro <[email protected]>
---
M util/dockerfiles/gcn-gpu/Dockerfile
1 file changed, 25 insertions(+), 3 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved
Matt Sinclair: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/util/dockerfiles/gcn-gpu/Dockerfile
b/util/dockerfiles/gcn-gpu/Dockerfile
index dee02b0..8dd1b1b 100644
--- a/util/dockerfiles/gcn-gpu/Dockerfile
+++ b/util/dockerfiles/gcn-gpu/Dockerfile
@@ -105,11 +105,11 @@
RUN git clone -b rocm-4.0.0 \
https://github.com/ROCmSoftwarePlatform/rocBLAS.git && mkdir
rocBLAS/build
-ENV HCC_AMDGPU_TARGET=gfx801
+ENV HCC_AMDGPU_TARGET=gfx801,gfx803,gfx900,gfx902
WORKDIR rocBLAS
-# rocBLAS needs to be built from source otherwise gfx801 gets an error in
HIP
+# rocBLAS needs to be built from source otherwise certain gfx versions get
errors in HIP
# about there being no GPU binary available
-RUN ./install.sh -d -a all -i
+RUN ./install.sh -d -i
WORKDIR /
# MIOpen dependencies + MIOpen
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/54623
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id1a00433beaa23f6935c12073d5bddc38431886b
Gerrit-Change-Number: 54623
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Kyle Roarty <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
