Matt Sinclair has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/47528 )
Change subject: configs: Set valid heap_type values
......................................................................
configs: Set valid heap_type values
The variables that were used to set heap_type don't exist.
Explicitly set them to the proper values.
Also add pointer to what heap value means in the ROCm stack.
Change-Id: I8df7fca7442f6640be1154ef147c4e302ea491bb
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/47528
Reviewed-by: Matt Sinclair <[email protected]>
Reviewed-by: Matthew Poremba <[email protected]>
Maintainer: Matt Sinclair <[email protected]>
Tested-by: kokoro <[email protected]>
---
M configs/example/hsaTopology.py
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved
Matt Sinclair: Looks good to me, but someone else must approve; Looks
good to me, approved
kokoro: Regressions pass
diff --git a/configs/example/hsaTopology.py b/configs/example/hsaTopology.py
index 28060cc..a4dbebb 100644
--- a/configs/example/hsaTopology.py
+++ b/configs/example/hsaTopology.py
@@ -140,7 +140,9 @@
# CPU memory reporting
mem_dir = joinpath(node_dir, 'mem_banks/0')
remake_dir(mem_dir)
- mem_prop = 'heap_type %s\n' % HsaHeaptype.HSA_HEAPTYPE_SYSTEM.value + \
+ # Heap type value taken from real system, heap type values:
+ #
https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/roc-4.0.x/include/hsakmttypes.h#L317
+ mem_prop = 'heap_type 0\n' +
\
'size_in_bytes 33704329216\n' + \
'flags 0\n' + \
'width 72\n' + \
@@ -221,7 +223,9 @@
# TODO: Extract size, clk, and width from sim paramters
mem_dir = joinpath(node_dir, 'mem_banks/0')
remake_dir(mem_dir)
- mem_prop = 'heap_type %s\n' % heap_type.value + \
+ # Heap type value taken from real system, heap type values:
+ #
https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/roc-4.0.x/include/hsakmttypes.h#L317
+ mem_prop = 'heap_type 1\n' + \
'size_in_bytes 17163091968\n' + \
'flags 0\n' + \
'width 2048\n' + \
@@ -316,6 +320,8 @@
# CPU memory reporting
mem_dir = joinpath(node_dir, 'mem_banks/0')
remake_dir(mem_dir)
+ # Heap type value taken from real system, heap type values:
+ #
https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/roc-4.0.x/include/hsakmttypes.h#L317
mem_prop = 'heap_type 0\n' + \
'size_in_bytes 33704329216\n' + \
'flags 0\n' + \
@@ -394,6 +400,8 @@
# TODO: Extract size, clk, and width from sim paramters
mem_dir = joinpath(node_dir, 'mem_banks/0')
remake_dir(mem_dir)
+ # Heap type value taken from real system, heap type values:
+ #
https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/roc-4.0.x/include/hsakmttypes.h#L317
mem_prop = 'heap_type 1\n' + \
'size_in_bytes 4294967296\n' + \
'flags 0\n' + \
@@ -471,6 +479,8 @@
mem_dir = joinpath(node_dir, f'mem_banks/{i}')
remake_dir(mem_dir)
+ # Heap type value taken from real system, heap type values:
+ #
https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/roc-4.0.x/include/hsakmttypes.h#L317
mem_prop = f'heap_type
0\n' + \
f'size_in_bytes
{toMemorySize(options.mem_size)}' + \
f'flags
0\n' + \
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/47528
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8df7fca7442f6640be1154ef147c4e302ea491bb
Gerrit-Change-Number: 47528
Gerrit-PatchSet: 4
Gerrit-Owner: Kyle Roarty <[email protected]>
Gerrit-Reviewer: Alex Dutu <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
