Bobby R. Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/47221 )
Change subject: util-gem5art: Fix mypy ignores in _artifactdb.py
......................................................................
util-gem5art: Fix mypy ignores in _artifactdb.py
With the current tests, theses lines were not ignored by mypy and caused
errors. This has been fixed.
Change-Id: Ib4fcb42c880a2b1d8a0a612ef35502c54bc8893a
---
M util/gem5art/artifact/gem5art/artifact/_artifactdb.py
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/gem5art/artifact/gem5art/artifact/_artifactdb.py
b/util/gem5art/artifact/gem5art/artifact/_artifactdb.py
index 4ffb0a0..d708ec6 100644
--- a/util/gem5art/artifact/gem5art/artifact/_artifactdb.py
+++ b/util/gem5art/artifact/gem5art/artifact/_artifactdb.py
@@ -242,10 +242,10 @@
"""
global _db
- # mypy bug: https://github.com/python/mypy/issues/5423
- if _db is not None and not uri: # type: ignore[unreachable]
- # If we have already established a connection, use that
- return _db # type: ignore[unreachable]
+ # mypy bug here: https://github.com/python/mypy/issues/5423.
+ if _db is not None and not uri: # type: ignore
+ # If we have already established a connection, use that
+ return _db # type: ignore
if not uri:
uri = os.environ.get("GEM5ART_DB", _default_uri)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/47221
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib4fcb42c880a2b1d8a0a612ef35502c54bc8893a
Gerrit-Change-Number: 47221
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby R. Bruce <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
