Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45005 )
Change subject: base: Collapse the DTRACE macro in DPRINTF.
......................................................................
base: Collapse the DTRACE macro in DPRINTF.
We've already checked if TRACING_ON is set, so we can just check the
value of Debug::x directly.
Change-Id: Ifcc183b9e56fd45a2c6278ab5739ae2fbe2b32c0
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45005
Tested-by: kokoro <[email protected]>
Maintainer: Gabe Black <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
---
M src/base/trace.hh
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/trace.hh b/src/base/trace.hh
index fec9822..c1804e8 100644
--- a/src/base/trace.hh
+++ b/src/base/trace.hh
@@ -174,27 +174,27 @@
*/
#define DDUMP(x, data, count) do { \
- if (M5_UNLIKELY(TRACING_ON && DTRACE(x))) \
+ if (M5_UNLIKELY(TRACING_ON && Debug::x)) \
Trace::getDebugLogger()->dump( \
curTick(), name(), data, count, #x); \
} while (0)
#define DPRINTF(x, ...) do { \
- if (M5_UNLIKELY(TRACING_ON && DTRACE(x))) { \
+ if (M5_UNLIKELY(TRACING_ON && Debug::x)) { \
Trace::getDebugLogger()->dprintf_flag( \
curTick(), name(), #x, __VA_ARGS__); \
} \
} while (0)
#define DPRINTFS(x, s, ...) do { \
- if (M5_UNLIKELY(TRACING_ON && DTRACE(x))) { \
+ if (M5_UNLIKELY(TRACING_ON && Debug::x)) { \
Trace::getDebugLogger()->dprintf_flag( \
curTick(), s->name(), #x, __VA_ARGS__); \
} \
} while (0)
#define DPRINTFR(x, ...) do { \
- if (M5_UNLIKELY(TRACING_ON && DTRACE(x))) { \
+ if (M5_UNLIKELY(TRACING_ON && Debug::x)) { \
Trace::getDebugLogger()->dprintf_flag( \
(Tick)-1, std::string(), #x, __VA_ARGS__); \
} \
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45005
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ifcc183b9e56fd45a2c6278ab5739ae2fbe2b32c0
Gerrit-Change-Number: 45005
Gerrit-PatchSet: 9
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
