Boris Shingarov has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40882 )
Change subject: arch-power: Fix disassembly for SPR move instructions
......................................................................
arch-power: Fix disassembly for SPR move instructions
This fixes disassembly generated for move-to and move-from
Special Purpose Register (SPR) instructions.
Change-Id: I03f10e3a44a8437beec453dfae2207d71ce43c1e
Signed-off-by: Sandipan Das <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40882
Reviewed-by: Boris Shingarov <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/power/insts/integer.cc
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Boris Shingarov: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/power/insts/integer.cc
b/src/arch/power/insts/integer.cc
index febd469..fdf3b51 100644
--- a/src/arch/power/insts/integer.cc
+++ b/src/arch/power/insts/integer.cc
@@ -42,12 +42,19 @@
std::string myMnemonic(mnemonic);
// Special cases
- if (!myMnemonic.compare("or") && srcRegIdx(0) == srcRegIdx(1)) {
+ if (myMnemonic == "or" && srcRegIdx(0) == srcRegIdx(1)) {
myMnemonic = "mr";
printSecondSrc = false;
- } else if (!myMnemonic.compare("mtlr") || !myMnemonic.compare("cmpi"))
{
+ } else if (myMnemonic == "mtcrf" ||
+ myMnemonic == "mtxer" ||
+ myMnemonic == "mtlr" ||
+ myMnemonic == "mtctr" ||
+ myMnemonic == "cmpi") {
printDest = false;
- } else if (!myMnemonic.compare("mflr")) {
+ } else if (myMnemonic == "mfcr" ||
+ myMnemonic == "mfxer" ||
+ myMnemonic == "mflr" ||
+ myMnemonic == "mfctr") {
printSrcs = false;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40882
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I03f10e3a44a8437beec453dfae2207d71ce43c1e
Gerrit-Change-Number: 40882
Gerrit-PatchSet: 7
Gerrit-Owner: Sandipan Das <[email protected]>
Gerrit-Reviewer: Boris Shingarov <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
