Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/39325 )
Change subject: arch: Remove copyMiscRegs from utility.hh.
......................................................................
arch: Remove copyMiscRegs from utility.hh.
This function is occasionally used internally in copyRegs, but is not
used by anything else and doesn't need to be publically exposed in the
header file.
Change-Id: Id02a77e7dd19c6c089a408bfe0099466822c523d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39325
Reviewed-by: Daniel Carvalho <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/utility.hh
M src/arch/mips/utility.cc
M src/arch/mips/utility.hh
M src/arch/power/utility.cc
M src/arch/power/utility.hh
M src/arch/sparc/utility.hh
M src/arch/x86/utility.hh
7 files changed, 3 insertions(+), 25 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/utility.hh b/src/arch/arm/utility.hh
index d38433e..5b3b849 100644
--- a/src/arch/arm/utility.hh
+++ b/src/arch/arm/utility.hh
@@ -87,12 +87,6 @@
void copyRegs(ThreadContext *src, ThreadContext *dest);
-static inline void
-copyMiscRegs(ThreadContext *src, ThreadContext *dest)
-{
- panic("Copy Misc. Regs Not Implemented Yet\n");
-}
-
/** Send an event (SEV) to a specific PE if there isn't
* already a pending event */
void sendEvent(ThreadContext *tc);
diff --git a/src/arch/mips/utility.cc b/src/arch/mips/utility.cc
index 911756f..a0c671f 100644
--- a/src/arch/mips/utility.cc
+++ b/src/arch/mips/utility.cc
@@ -224,10 +224,4 @@
dest->pcState(src->pcState());
}
-void
-copyMiscRegs(ThreadContext *src, ThreadContext *dest)
-{
- panic("Copy Misc. Regs Not Implemented Yet\n");
-}
-
} // namespace MipsISA
diff --git a/src/arch/mips/utility.hh b/src/arch/mips/utility.hh
index eb7f74a..1804680 100644
--- a/src/arch/mips/utility.hh
+++ b/src/arch/mips/utility.hh
@@ -73,7 +73,6 @@
}
void copyRegs(ThreadContext *src, ThreadContext *dest);
-void copyMiscRegs(ThreadContext *src, ThreadContext *dest);
inline void
advancePC(PCState &pc, const StaticInstPtr &inst)
diff --git a/src/arch/power/utility.cc b/src/arch/power/utility.cc
index 1c68cd9..ffcbe4f 100644
--- a/src/arch/power/utility.cc
+++ b/src/arch/power/utility.cc
@@ -32,7 +32,8 @@
#include "base/logging.hh"
-namespace PowerISA {
+namespace PowerISA
+{
void
copyRegs(ThreadContext *src, ThreadContext *dest)
@@ -45,8 +46,7 @@
for (int i = 0; i < NumFloatRegs; ++i)
dest->setFloatReg(i, src->readFloatReg(i));
- // Copy misc. registers
- copyMiscRegs(src, dest);
+ //TODO Copy misc. registers.
// Lastly copy PC/NPC
dest->pcState(src->pcState());
diff --git a/src/arch/power/utility.hh b/src/arch/power/utility.hh
index 7c892d4..03df7fb 100644
--- a/src/arch/power/utility.hh
+++ b/src/arch/power/utility.hh
@@ -39,11 +39,6 @@
void copyRegs(ThreadContext *src, ThreadContext *dest);
-static inline void
-copyMiscRegs(ThreadContext *src, ThreadContext *dest)
-{
-}
-
inline void
advancePC(PCState &pc, const StaticInstPtr &inst)
{
diff --git a/src/arch/sparc/utility.hh b/src/arch/sparc/utility.hh
index e61989a..f179c17 100644
--- a/src/arch/sparc/utility.hh
+++ b/src/arch/sparc/utility.hh
@@ -43,8 +43,6 @@
void copyRegs(ThreadContext *src, ThreadContext *dest);
-void copyMiscRegs(ThreadContext *src, ThreadContext *dest);
-
inline void
advancePC(PCState &pc, const StaticInstPtr &inst)
{
diff --git a/src/arch/x86/utility.hh b/src/arch/x86/utility.hh
index a7c2dfc..9cd4e94 100644
--- a/src/arch/x86/utility.hh
+++ b/src/arch/x86/utility.hh
@@ -46,8 +46,6 @@
{
void copyRegs(ThreadContext *src, ThreadContext *dest);
- void copyMiscRegs(ThreadContext *src, ThreadContext *dest);
-
inline void
advancePC(PCState &pc, const StaticInstPtr &inst)
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39325
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id02a77e7dd19c6c089a408bfe0099466822c523d
Gerrit-Change-Number: 39325
Gerrit-PatchSet: 10
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
