Tiago Mück has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/41153 )
Change subject: mem-ruby: fix functional reads in abstract ctrl
......................................................................
mem-ruby: fix functional reads in abstract ctrl
When calling functionalMemoryRead we need to check the mem req. queue
first as it may have write data not yet forwarded to the memory port.
Change-Id: Id37aa0837a3462d92ae9ac3b45ca756b2c4f7d97
Signed-off-by: Tiago Mück <tiago.m...@arm.com>
---
M src/mem/ruby/slicc_interface/AbstractController.cc
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mem/ruby/slicc_interface/AbstractController.cc
b/src/mem/ruby/slicc_interface/AbstractController.cc
index 1222631..b7da81e 100644
--- a/src/mem/ruby/slicc_interface/AbstractController.cc
+++ b/src/mem/ruby/slicc_interface/AbstractController.cc
@@ -317,7 +317,10 @@
void
AbstractController::functionalMemoryRead(PacketPtr pkt)
{
- memoryPort.sendFunctional(pkt);
+ // read from mem. req. queue if write data is pending there
+ MessageBuffer *req_queue = getMemReqQueue();
+ if (!req_queue || !req_queue->functionalRead(pkt))
+ memoryPort.sendFunctional(pkt);
}
int
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/41153
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id37aa0837a3462d92ae9ac3b45ca756b2c4f7d97
Gerrit-Change-Number: 41153
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Mück <tiago.m...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
