Earl Ou has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40276 )
Change subject: fastmodel: remove incorrect cntfrq update
......................................................................
fastmodel: remove incorrect cntfrq update
The register cntfrq should be set to system counter frequency.
However, the current fastmodel implementation accidentally set it to
core frequency. This CL removes the wrong implementation, and real
cntfrq setting is performed in the initState.
Change-Id: I6c62822a4fbbcc0c499f79f6003dabb0c133f997
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40276
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/fastmodel/CortexA76/cortex_a76.hh
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/fastmodel/CortexA76/cortex_a76.hh
b/src/arch/arm/fastmodel/CortexA76/cortex_a76.hh
index 68ff1a8..724b04d 100644
--- a/src/arch/arm/fastmodel/CortexA76/cortex_a76.hh
+++ b/src/arch/arm/fastmodel/CortexA76/cortex_a76.hh
@@ -66,19 +66,6 @@
Base(p, scx::scx_get_iris_connection_interface()), _params(p)
{}
- void
- clockPeriodUpdated() override
- {
- Base::clockPeriodUpdated();
-
- // FIXME(b/139447397): this is a workaround since CNTFRQ_EL0
should not
- // be modified after clock is changed in real hardwares. Remove or
- // modify this after a more reasonable solution is found.
- for (auto *tc : threadContexts) {
- tc->setMiscRegNoEffect(ArmISA::MISCREG_CNTFRQ_EL0,
frequency());
- }
- }
-
void initState() override;
template <class T>
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40276
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I6c62822a4fbbcc0c499f79f6003dabb0c133f997
Gerrit-Change-Number: 40276
Gerrit-PatchSet: 3
Gerrit-Owner: Earl Ou <[email protected]>
Gerrit-Reviewer: Earl Ou <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Yu-hsin Wang <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
