Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/38537 )
Change subject: x86: Fix some comments in x86 KVM process initialization.
......................................................................
x86: Fix some comments in x86 KVM process initialization.
These comments did not reflect what the code was actually doing.
Change-Id: I2bcd23bd68c870e364bdfd0b9b0eb5dcb560e713
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38537
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/x86/process.cc
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/process.cc b/src/arch/x86/process.cc
index 25f556c..03e8641 100644
--- a/src/arch/x86/process.cc
+++ b/src/arch/x86/process.cc
@@ -343,8 +343,8 @@
efer.lme = 1; // Enable long mode.
efer.lma = 1; // Activate long mode.
efer.nxe = 1; // Enable nx support.
- efer.svme = 0; // Enable svm support for now.
- efer.ffxsr = 0; // Turn on fast fxsave and fxrstor.
+ efer.svme = 0; // Disable svm support for now.
+ efer.ffxsr = 0; // Disable fast fxsave and fxrstor.
tc->setMiscReg(MISCREG_EFER, efer);
//Set up the registers that describe the operating mode.
@@ -372,7 +372,7 @@
CR4 cr4 = 0;
//Turn on pae.
- cr4.osxsave = 0; // Enable XSAVE and Proc Extended States
+ cr4.osxsave = 0; // Disable XSAVE and Proc Extended States
cr4.osxmmexcpt = 0; // Operating System Unmasked Exception
cr4.osfxsr = 1; // Operating System FXSave/FSRSTOR Support
cr4.pce = 0; // Performance-Monitoring Counter Enable
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38537
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I2bcd23bd68c870e364bdfd0b9b0eb5dcb560e713
Gerrit-Change-Number: 38537
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Alexandru Duțu <alexandru.d...@amd.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
