Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/36282 )
Change subject: misc: Fix a few accidental transitive includes.
......................................................................
misc: Fix a few accidental transitive includes.
Some files depend on definitions from files that they weren't including
themselves. They were working accidentally by getting those definitions
transitively through other, unrelated headers.
Change-Id: I50c919a4eb6c4484d4ee6b7f4fe02f075132964d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/36282
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/riscv/pagetable.hh
M src/arch/riscv/registers.hh
M src/dev/arm/timer_a9global.hh
M src/dev/ps2/mouse.hh
M src/dev/x86/i8042.hh
M src/mem/cache/compressors/dictionary_compressor.hh
M src/mem/page_table.hh
M src/sim/pseudo_inst.hh
8 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/riscv/pagetable.hh b/src/arch/riscv/pagetable.hh
index bb65805..d3c123e 100644
--- a/src/arch/riscv/pagetable.hh
+++ b/src/arch/riscv/pagetable.hh
@@ -31,6 +31,7 @@
#ifndef __ARCH_RISCV_PAGETABLE_H__
#define __ARCH_RISCV_PAGETABLE_H__
+#include "base/bitunion.hh"
#include "base/logging.hh"
#include "base/trie.hh"
#include "base/types.hh"
diff --git a/src/arch/riscv/registers.hh b/src/arch/riscv/registers.hh
index 7ce59e3..ed8b916 100644
--- a/src/arch/riscv/registers.hh
+++ b/src/arch/riscv/registers.hh
@@ -53,6 +53,7 @@
#include "arch/generic/vec_pred_reg.hh"
#include "arch/generic/vec_reg.hh"
#include "arch/riscv/generated/max_inst_regs.hh"
+#include "base/bitunion.hh"
#include "base/types.hh"
namespace RiscvISA {
diff --git a/src/dev/arm/timer_a9global.hh b/src/dev/arm/timer_a9global.hh
index aea02cb..7a8cf85 100644
--- a/src/dev/arm/timer_a9global.hh
+++ b/src/dev/arm/timer_a9global.hh
@@ -39,6 +39,7 @@
#ifndef __DEV_ARM_GLOBAL_TIMER_HH__
#define __DEV_ARM_GLOBAL_TIMER_HH__
+#include "base/bitunion.hh"
#include "dev/io_device.hh"
#include "params/A9GlobalTimer.hh"
diff --git a/src/dev/ps2/mouse.hh b/src/dev/ps2/mouse.hh
index 7a1ef21..0a526db 100644
--- a/src/dev/ps2/mouse.hh
+++ b/src/dev/ps2/mouse.hh
@@ -41,6 +41,7 @@
#ifndef __DEV_PS2_MOUSE_HH__
#define __DEV_PS2_MOUSE_HH__
+#include "base/bitunion.hh"
#include "dev/ps2/device.hh"
struct PS2MouseParams;
diff --git a/src/dev/x86/i8042.hh b/src/dev/x86/i8042.hh
index 10681da..4fc6311 100644
--- a/src/dev/x86/i8042.hh
+++ b/src/dev/x86/i8042.hh
@@ -31,6 +31,7 @@
#include <deque>
+#include "base/bitunion.hh"
#include "dev/intpin.hh"
#include "dev/io_device.hh"
#include "dev/ps2/device.hh"
diff --git a/src/mem/cache/compressors/dictionary_compressor.hh
b/src/mem/cache/compressors/dictionary_compressor.hh
index bc9f49a..5b8ca23 100644
--- a/src/mem/cache/compressors/dictionary_compressor.hh
+++ b/src/mem/cache/compressors/dictionary_compressor.hh
@@ -51,6 +51,7 @@
#include <type_traits>
#include <vector>
+#include "base/bitfield.hh"
#include "base/statistics.hh"
#include "base/types.hh"
#include "mem/cache/compressors/base.hh"
diff --git a/src/mem/page_table.hh b/src/mem/page_table.hh
index 8b664f8..18ee18a 100644
--- a/src/mem/page_table.hh
+++ b/src/mem/page_table.hh
@@ -38,6 +38,7 @@
#include <string>
#include <unordered_map>
+#include "base/bitfield.hh"
#include "base/intmath.hh"
#include "base/types.hh"
#include "mem/request.hh"
diff --git a/src/sim/pseudo_inst.hh b/src/sim/pseudo_inst.hh
index 8135ee0..c32243a 100644
--- a/src/sim/pseudo_inst.hh
+++ b/src/sim/pseudo_inst.hh
@@ -47,6 +47,7 @@
#include "arch/pseudo_inst.hh"
#include "arch/utility.hh"
+#include "base/bitfield.hh"
#include "base/types.hh" // For Tick and Addr data types.
#include "debug/PseudoInst.hh"
#include "sim/guest_abi.hh"
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/36282
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I50c919a4eb6c4484d4ee6b7f4fe02f075132964d
Gerrit-Change-Number: 36282
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
