Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/35216 )
Change subject: base,mem: Use the standard [[deprecated]] attribute.
......................................................................
base,mem: Use the standard [[deprecated]] attribute.
The [[deprecated]] attribute is now standard, and so we don't need to
wrap it in our own macro any more.
Change-Id: I363df9a9c6b820dee8c21b1716335c0d15fbc62d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/35216
Maintainer: Gabe Black <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/base/compiler.hh
M src/mem/mem_object.hh
M src/mem/port.hh
3 files changed, 4 insertions(+), 6 deletions(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/compiler.hh b/src/base/compiler.hh
index c2eb5d9..e28d45e 100644
--- a/src/base/compiler.hh
+++ b/src/base/compiler.hh
@@ -49,8 +49,6 @@
# define M5_VAR_USED __attribute__((unused))
# define M5_ATTR_PACKED __attribute__ ((__packed__))
# define M5_NO_INLINE __attribute__ ((__noinline__))
-# define M5_DEPRECATED __attribute__((deprecated))
-# define M5_DEPRECATED_MSG(MSG) __attribute__((deprecated(MSG)))
# define M5_UNREACHABLE __builtin_unreachable()
# define M5_PUBLIC __attribute__ ((visibility ("default")))
# define M5_LOCAL __attribute__ ((visibility ("hidden")))
diff --git a/src/mem/mem_object.hh b/src/mem/mem_object.hh
index 7cce0c9..5220836 100644
--- a/src/mem/mem_object.hh
+++ b/src/mem/mem_object.hh
@@ -55,8 +55,8 @@
class MemObject : public ClockedObject
{
public:
- M5_DEPRECATED_MSG(
- "MemObject is deprecated. Use ClockedObject or SimObject
instead")
+ [[deprecated(
+ "MemObject is deprecated. Use ClockedObject or SimObject
instead")]]
MemObject(const MemObjectParams *params) : ClockedObject(params)
{}
};
diff --git a/src/mem/port.hh b/src/mem/port.hh
index c933af62..357a10e 100644
--- a/src/mem/port.hh
+++ b/src/mem/port.hh
@@ -245,7 +245,7 @@
}
};
-class M5_DEPRECATED MasterPort : public RequestPort
+class [[deprecated]] MasterPort : public RequestPort
{
public:
MasterPort(const std::string& name, SimObject* _owner,
@@ -449,7 +449,7 @@
}
};
-class M5_DEPRECATED SlavePort : public ResponsePort
+class [[deprecated]] SlavePort : public ResponsePort
{
public:
SlavePort(const std::string& name, SimObject* _owner,
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/35216
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I363df9a9c6b820dee8c21b1716335c0d15fbc62d
Gerrit-Change-Number: 35216
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
