Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/34815 )
Change subject: sim: Remove check whether the System port is connected.
......................................................................
sim: Remove check whether the System port is connected.
The port will report an error if something tries to use it and
it's not connected. If it isn't needed, there's no reason to force
users to hook something up to it just to satisfy the check.
Change-Id: I0668b8a86c8cb323aba51670fb7914d35acc5198
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34815
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/sim/system.cc
M src/sim/system.hh
2 files changed, 0 insertions(+), 13 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve
Andreas Sandberg: Looks good to me, approved
Nikos Nikoleris: Looks good to me, but someone else must approve
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/system.cc b/src/sim/system.cc
index cbc30a9..39b3414 100644
--- a/src/sim/system.cc
+++ b/src/sim/system.cc
@@ -273,14 +273,6 @@
}
void
-System::init()
-{
- // check that the system port is connected
- if (!_systemPort.isConnected())
- panic("System port on %s is not connected.\n", name());
-}
-
-void
System::startup()
{
SimObject::startup();
diff --git a/src/sim/system.hh b/src/sim/system.hh
index fc93b85..e5d4ec6 100644
--- a/src/sim/system.hh
+++ b/src/sim/system.hh
@@ -221,11 +221,6 @@
const_iterator end() const { return const_iterator(*this, size());
}
};
- /**
- * After all objects have been created and all ports are
- * connected, check that the system port is connected.
- */
- void init() override;
void startup() override;
/**
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34815
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0668b8a86c8cb323aba51670fb7914d35acc5198
Gerrit-Change-Number: 34815
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
