Kyle Roarty has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32676 )
Change subject: configs: Add parameter for GPU scalar cache mandatory queue
size
......................................................................
configs: Add parameter for GPU scalar cache mandatory queue size
There was a missing option (--buffers-size) used to set the mandatory
queue size for the scalar controllers. This patch renames the option to
be more clear, and adds it to the argument parser.
Default of 128 taken from the implementation on the GCN staging branch
Change-Id: I58b6b57be07498cdf6e39c0bb85982674ec4caa6
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32676
Reviewed-by: Matt Sinclair <[email protected]>
Maintainer: Anthony Gutierrez <[email protected]>
Tested-by: kokoro <[email protected]>
---
M configs/ruby/GPU_VIPER.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Matt Sinclair: Looks good to me, approved
Anthony Gutierrez: Looks good to me, approved
kokoro: Regressions pass
diff --git a/configs/ruby/GPU_VIPER.py b/configs/ruby/GPU_VIPER.py
index 50ccd2b..6a6dec5 100644
--- a/configs/ruby/GPU_VIPER.py
+++ b/configs/ruby/GPU_VIPER.py
@@ -399,6 +399,9 @@
parser.add_option("--noL1", action = "store_true", default = False,
help = "bypassL1")
+ parser.add_option("--scalar-buffer-size", type = 'int', default = 128,
+ help="Size of the mandatory queue in the GPU scalar "
+ "cache controller")
def create_system(options, full_system, system, dma_devices, bootmem,
ruby_system):
@@ -676,7 +679,7 @@
scalar_cntrl.responseToSQC.slave = ruby_system.network.master
scalar_cntrl.mandatoryQueue = \
- MessageBuffer(buffer_size=options.buffers_size)
+ MessageBuffer(buffer_size=options.scalar_buffer_size)
gpuCluster.add(scalar_cntrl)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32676
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I58b6b57be07498cdf6e39c0bb85982674ec4caa6
Gerrit-Change-Number: 32676
Gerrit-PatchSet: 6
Gerrit-Owner: Kyle Roarty <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Kyle Roarty <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
