Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/33375 )
Change subject: mem-cache: Fix RepeatedQwords compressor
......................................................................
mem-cache: Fix RepeatedQwords compressor
This compressor does not allocate dictionary entries when there
is a match. This was causing the compressor to always fail.
Change-Id: I50eb56fa284854f3ee87f33af2c6e0a5c5248d7c
Signed-off-by: Daniel R. Carvalho <[email protected]>
---
M src/mem/cache/compressors/dictionary_compressor.hh
M src/mem/cache/compressors/repeated_qwords.hh
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/mem/cache/compressors/dictionary_compressor.hh
b/src/mem/cache/compressors/dictionary_compressor.hh
index 650edab..b9c68a1 100644
--- a/src/mem/cache/compressors/dictionary_compressor.hh
+++ b/src/mem/cache/compressors/dictionary_compressor.hh
@@ -563,9 +563,10 @@
const uint64_t code,
const uint64_t metadata_length,
const int match_location,
- const DictionaryEntry bytes)
+ const DictionaryEntry bytes,
+ const bool allocate = true)
: MaskedPattern<mask>(number, code, metadata_length, match_location,
- bytes)
+ bytes, allocate)
{
}
diff --git a/src/mem/cache/compressors/repeated_qwords.hh
b/src/mem/cache/compressors/repeated_qwords.hh
index c361900..9a2df3c 100644
--- a/src/mem/cache/compressors/repeated_qwords.hh
+++ b/src/mem/cache/compressors/repeated_qwords.hh
@@ -116,7 +116,7 @@
public:
PatternM(const DictionaryEntry bytes, const int match_location)
: LocatedMaskedPattern<0xFFFFFFFFFFFFFFFF, 0>(M, 1, 0,
match_location,
- bytes)
+ bytes, false)
{
}
};
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33375
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I50eb56fa284854f3ee87f33af2c6e0a5c5248d7c
Gerrit-Change-Number: 33375
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
