Andreas Sandberg has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/33295 )

Change subject: dev: Use the new ByteOrder param type in SimpleUart
......................................................................

dev: Use the new ByteOrder param type in SimpleUart

Use the new ByteOrder param type in SimpleUart. The default value is
inherited from a parent object (likely the system) with a byte_order
param.

Change-Id: I3f5d4ea566e5127474cff976332bd53c5b49b9e2
Signed-off-by: Andreas Sandberg <[email protected]>
---
M src/dev/serial/Uart.py
M src/dev/serial/simple.cc
2 files changed, 2 insertions(+), 4 deletions(-)



diff --git a/src/dev/serial/Uart.py b/src/dev/serial/Uart.py
index 97efcdd..5e64481 100644
--- a/src/dev/serial/Uart.py
+++ b/src/dev/serial/Uart.py
@@ -52,7 +52,7 @@
 class SimpleUart(Uart):
     type = 'SimpleUart'
     cxx_header = "dev/serial/simple.hh"
-    big_endian = Param.Bool(False, "Is the device Big Endian?")
+    byte_order = Param.ByteOrder(Parent.byte_order, "Device byte order")
     pio_size = Param.Addr(0x4, "Size of address range")
     end_on_eot = Param.Bool(False, "End the simulation when a EOT is "\
                             "received on the UART")
diff --git a/src/dev/serial/simple.cc b/src/dev/serial/simple.cc
index 97018ab..339d6b9 100644
--- a/src/dev/serial/simple.cc
+++ b/src/dev/serial/simple.cc
@@ -43,9 +43,7 @@
 #include "sim/sim_exit.hh"

 SimpleUart::SimpleUart(const SimpleUartParams *p)
-    : Uart(p, p->pio_size),
-      byteOrder(p->big_endian ? ByteOrder::big : ByteOrder::little),
-      endOnEOT(p->end_on_eot)
+ : Uart(p, p->pio_size), byteOrder(p->byte_order), endOnEOT(p->end_on_eot)
 {
 }


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33295
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I3f5d4ea566e5127474cff976332bd53c5b49b9e2
Gerrit-Change-Number: 33295
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to