Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32924 )
Change subject: kern: Stop using TheISA::GuestByteOrder in Linux::dumpDmesg.
......................................................................
kern: Stop using TheISA::GuestByteOrder in Linux::dumpDmesg.
This value is already read from the system object in that same function.
We should use that instead of getting the value ourselves.
Change-Id: I0a442cd4892f50ad0179884bebf3eb52881c022f
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32924
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/kern/linux/helpers.cc
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/kern/linux/helpers.cc b/src/kern/linux/helpers.cc
index 4cbac41..028ad8a 100644
--- a/src/kern/linux/helpers.cc
+++ b/src/kern/linux/helpers.cc
@@ -109,12 +109,9 @@
return;
}
- uint32_t log_buf_len =
- proxy.read<uint32_t>(lb_len->address, TheISA::GuestByteOrder);
- uint32_t log_first_idx =
- proxy.read<uint32_t>(first->address, TheISA::GuestByteOrder);
- uint32_t log_next_idx =
- proxy.read<uint32_t>(next->address, TheISA::GuestByteOrder);
+ uint32_t log_buf_len = proxy.read<uint32_t>(lb_len->address, bo);
+ uint32_t log_first_idx = proxy.read<uint32_t>(first->address, bo);
+ uint32_t log_next_idx = proxy.read<uint32_t>(next->address, bo);
if (log_first_idx >= log_buf_len || log_next_idx >= log_buf_len) {
warn("dmesg pointers/length corrupted\n");
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32924
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0a442cd4892f50ad0179884bebf3eb52881c022f
Gerrit-Change-Number: 32924
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Emily Brickey <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
