Hi all, Generally, I think that any code that doesn't have tests and we are not actively supporting should be removed. We can always resurrect it with about the same amount of work as getting it up to date today. Plus, we can now say "the code is available in gem5-20."
We have an extremely lean development team, most of which are contributing to gem5 in their "spare time." Supporting such a sprawling codebase is taking time away from making deeper and more impactful changes. In conclusion, I think you should remove the code! Cheers, Jason On Wed, Aug 19, 2020 at 3:31 AM Gabe Black via gem5-dev <[email protected]> wrote: > Hi folks. I was doing some spelunking trying to eliminate more ISA related > dependencies from common code, and I ran across the CPA (critical path > annotation) support in, among maybe a few other places, base/cp_annotate.cc. > > This code can't actually compile since it depends on there being a > TheISA::IPR_PALtemp23 register index defined, and possibly from that name > you might guess that that is not actually defined by any ISA anywhere. It > would have been defined in Alpha, but that's gone now. I vaguely remember > this being something Ali developed long ago but don't remember anything > else (or maybe ever knew anything else?) about it. I did see some stuff > related to it in the pseudoInst code, but it looked like that had been > partially removed already. > > This file is gated behind a CP_ANNOTATE flag accepted by scons which is > why it doesn't blow up in day to day use. > > I think we have three choices as far as what to do with this code: > > 1. Leave it alone and keep ignoring it, possibly to do something with it > in the future. > 2. Delete it. > 3. Figure out what it's doing and make it work for other/all ISAs. > > Since I don't even really know what it does and it's currently > uncompilable, my vote would be for number 2. What do other folks think? > > Gabe > _______________________________________________ > gem5-dev mailing list -- [email protected] > To unsubscribe send an email to [email protected] > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
_______________________________________________ gem5-dev mailing list -- [email protected] To unsubscribe send an email to [email protected] %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
