Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32556 )
Change subject: util: Remove dependency check
......................................................................
util: Remove dependency check
The list is rather old and it contains some entries which are likely
unneeded. Since we are also now able to select specific FS binaries
to be compiled individually, there is not point of requiring all
components to be installed.
Instead, if is better to rely on the error message of building process
and let the users figure out which packages they need to install
Change-Id: I16c74861cb1f2b09c3e91e408ace01a9bd7a234d
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32556
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M util/gen_arm_fs_files.py
1 file changed, 0 insertions(+), 24 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/util/gen_arm_fs_files.py b/util/gen_arm_fs_files.py
index 2f339a2..986dda4 100755
--- a/util/gen_arm_fs_files.py
+++ b/util/gen_arm_fs_files.py
@@ -292,30 +292,6 @@
print "Error: %s already exists." %revisions_dir
sys.exit(1)
-# Some basic dependency checking
-needed_programs = [
- "make",
- "aarch64-linux-gnu-gcc",
- "arm-linux-gnueabihf-gcc",
- "aarch64-linux-gnu-gcc-4.8",
- "arm-linux-gnueabihf-gcc-4.8",
- "gcc",
- "bc",
- "dtc",
- "arm-linux-gnueabi-gcc"
-]
-
-for program in needed_programs:
- if not spawn.find_executable(program):
- print "Error: command %s not found in $PATH" % program
- print ("If running on an Debian-based linux, please try the
following "
- "cmd to get all the necessary packages: ")
- print ("sudo apt-get install -y make gcc bc gcc-aarch64-linux-gnu "
- "gcc-4.8-aarch64-linux-gnu gcc-4.8-arm-linux-gnueabihf "
- "gcc-arm-linux-gnueabihf device-tree-compiler "
- "gcc-arm-linux-gnueabi")
- sys.exit(1)
-
os.mkdir(binaries_dir);
os.mkdir(revisions_dir);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32556
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I16c74861cb1f2b09c3e91e408ace01a9bd7a234d
Gerrit-Change-Number: 32556
Gerrit-PatchSet: 3
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
