[AMD Official Use Only - Approved for External Use]

Hi Sampad,


I'm fairly certain the map call is not needed. The scripts I use do not have 
this, for example. My guess is this was intended to be 
"map(hsapp_gpu_map_vaddr, hsapp_gpu_map_paddr, hsapp_gpu_map_size)".  If that 
is the case the unused variables and the map call can be removed from the 
script.


-Matt

From: Matt Sinclair <[email protected]>
Sent: Wednesday, August 5, 2020 10:32 AM
To: gem5 Developer List <[email protected]>
Cc: Poremba, Matthew <[email protected]>; Beckmann, Brad 
<[email protected]>; Gutierrez, Anthony <[email protected]>; Dutu, 
Alexandru <[email protected]>
Subject: Re: [gem5-dev] AMD GCN3 - HSA Memory Mapping

[CAUTION: External Email]
Hi Sampad,

I don't know the answer to this question directly, but I'm CC'ing the AMD folks 
who hopefully can provide the answer.  I mentioned this to Matt P earlier and 
he thinks it may be a bug.

Thanks,
Matt

On Fri, Jul 31, 2020 at 10:47 AM Sampad Mohapatra via gem5-dev 
<[email protected]<mailto:[email protected]>> wrote:
Hi All,

I have two queries related to apu_se.py.

(1)
In both AMD staging and public/develop, apu_se.py has two unused variables:

  hsapp_gpu_map_vaddr = 0x200000000
  hsapp_gpu_map_size = 0x1000

Are they unnecessary or should they actually be used somewhere ?

(2)
The following is passed as pioAddr to the HSAPacketProcessor.
  hsapp_gpu_map_paddr = int(Addr(options.mem_size))

And then the following assignment is done.
  # Map workload to this address space
  host_cpu.workload[0].map(0x10000000, 0x200000000, 4096)

Should the physical address to the workload map be the same as pioAddr of 
HSAPacketProcessor, i.e. greater than physical memory size and should the 
virtual address of the workload map remain 0x10000000 ?

As a whole, are the above mentioned variables related ? If yes, then how ?
Are some of them accidentally hardcoded and should actually be variables?
Please advise.

Thank you,
Sampad
_______________________________________________
gem5-dev mailing list -- [email protected]<mailto:[email protected]>
To unsubscribe send an email to 
[email protected]<mailto:[email protected]>
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to