Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30594 )
Change subject: sim: Fix -Werror=maybe-uninitialized in system.cc
......................................................................
sim: Fix -Werror=maybe-uninitialized in system.cc
The patch is simply initializing when to 0 before unserializing
the real value
Change-Id: I4e19eeafa9334116b440948af1943f3835803671
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30594
Tested-by: kokoro <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/sim/system.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/system.cc b/src/sim/system.cc
index 4133412..6e5975e 100644
--- a/src/sim/system.cc
+++ b/src/sim/system.cc
@@ -447,7 +447,7 @@
UNSERIALIZE_SCALAR(pagePtr);
for (auto &t: threads.threads) {
- Tick when;
+ Tick when = 0;
ContextID id = t.context->contextId();
if (!optParamIn(cp, csprintf("quiesceEndTick_%d", id), when) ||
!when || !t.resumeEvent) {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30594
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4e19eeafa9334116b440948af1943f3835803671
Gerrit-Change-Number: 30594
Gerrit-PatchSet: 4
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
