My personal take: I slightly Hungarian notation and it seems to me like needing that extra notation points to other coding style issues. However, I think moving away from it would be a chaotic mess for GDAL. It would be a massive change to switch it all. Consistency is critical.
On Wed, Apr 17, 2024 at 9:10 AM Even Rouault via gdal-dev < gdal-dev@lists.osgeo.org> wrote: > Hi, > > This is described in https://gdal.org/development/rfc/rfc8_devguide.html > . I've submitted https://github.com/OSGeo/gdal/pull/9689 so it is going > to be linked to > https://gdal.org/development/dev_practices.html#making-changes-to-gdal > > I'd probably agree that at my beginnings in GDAL, I might have felt > unfamiliar with the Hungarian notation, but now I've fully internalized it, > so I hardly notice it. It would be interesting to have opinions of other > developers if they find it inconvenient/a hurdle, are neutral or like it. > The thing is that if we decide to no longer use it, the inconsistency of > mixing free style naming and Hungarian notation might be problematic and > make code confusing. We should probably aim at being consistent at least at > the scope of a given function or file. > > Even > Le 17/04/2024 à 15:48, Andrew Bell via gdal-dev a écrit : > > Hi, > > I was going to make some changes to some GDAL code and I generally want to > follow along. I see that most of the code is still using Hungarian notation > for identifier names. I haven't seen this anywhere else in like 20 years. > > Is it OK to submit code without this naming convention or do we still > think it's important. I didn't see an RFC or documentation that covers > this, but there's lots so I may have missed it. > > Thanks, > > -- > Andrew Bell > andrew.bell...@gmail.com > > _______________________________________________ > gdal-dev mailing > listgdal-dev@lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/gdal-dev > > -- http://www.spatialys.com > My software is free, but my time generally not. > > _______________________________________________ > gdal-dev mailing list > gdal-dev@lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/gdal-dev >
_______________________________________________ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
