Which version of clang-format are we using? (I saw 3.8 somewhere n the code?) Older versions are not easy to get in modern operating systems. In Ubuntu 22.04 the default is clang-format-14. It is specially hard in MacOS, friends told me.
About the blame problems, we can do this: https://akrabat.com/ignoring-revisions-with-git-blame/ Thanks for the work! On Mon, 28 Nov 2022, 17:14 Even Rouault, <[email protected]> wrote: > Hi, > > +1 and I'm very much for the "Big reformat", otherwise as discussed with > Alessandro, I'm afraid occasional contributors will mix substantial and > formatting changes in the same commit. The Big reformat commit itself > should be done with a dedicated github account, like we did with the > "git mv gdal/* ." tree-reorganisation to avoid unfair commit statistics. > > I've just tested successfully the proposed clang-format pre-commit hook > on Windows, so this shouldn't be an obstacle to contributors whatever > their development environment. > > Even > > Le 24/11/2022 à 09:39, ElPaso a écrit : > > Hi, > > > > Motion: > > > > Adopt RFC88: RFC69 C/C++ Code Formatting [1] > > > > I have updated the RFC [1] to use pre-commit and I have created a > > draft implementation of the pre-commit hook and the CI integration > > with a GH workflow [2]. > > > > If adopted, we still have to agree on which coding style to apply (for > > now I used a clang-format file I've found under gdal/scripts), but the > > biggest decision is wether proceed with an initial "Big Reformat" or > > an incremental one, my draft implementation supports both. > > > > > > Kind regards. > > > > > > [1] > > > https://github.com/elpaso/gdal/blob/rfc69_cplusplus_formatting-text-only/doc/source/development/rfc/rfc69_cplusplus_formatting.rst > > [2] > > https://github.com/elpaso/gdal/tree/rfc69_cplusplus_formatting_revival > > > -- > http://www.spatialys.com > My software is free, but my time generally not. > > _______________________________________________ > gdal-dev mailing list > [email protected] > https://lists.osgeo.org/mailman/listinfo/gdal-dev >
_______________________________________________ gdal-dev mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/gdal-dev
