Hello. Is this the correct sequence for regression test: 1. Revert back all the changes I made and then configure, build along with make bootstrap make -k check collect the *.sum files 2. Apply the patch and do the configuration, build as above 1 and then collect the *.sum files and compare them.
How do I collect and inspect these *.sum files? Thanks, -Tejas On Thu, 6 Jun 2019 at 22:26, Martin Jambor <mjam...@suse.cz> wrote: > > Hi, > > On Mon, Jun 03 2019, Tejas Joshi wrote: > > Hello. > > I have already sent a patch for roundeven implementation but I do not > > know how do I commit my changes to GCC. Am I supposed to create a > > branch or anything etc? > > You don't have to create a branch unless you think it would make ease > your own workflow. Once a patch is ready to go and has been explicitely > approved by a corresponding maintainer, you will be expected to commit > it directly to svn (we'll ask for a svn write access for you when we get > to that point). You'll find the list of maintainers in the MAINTAINERS > file of the gcc repository, I believe your patches will need approval > from a global reviewer, most probably Joseph. > > Before that happens, the code must be of course considered correct but > also must adhere to some conventions, please see > https://gcc.gnu.org/codingconventions.html. Your patches so far lacked > a ChangeLog and testcases. Have a look at what other do when they post > patches to gcc-patches: https://gcc.gnu.org/ml/gcc-patches/2019-06/ > > ChangeLog has to have the given, fairly strict format, but should be > very brief. When posting patches, you don't make it part of the patch > even though when committing, you are expected it to prepend the > corresponding ChangeLog file with your bit (see e.g. gcc/ChangeLog and > gcc/testsuite/ChangeLog). > > You have always stated how you tested your patches but you are actually > supposed to add the testsuite and committed along with the functional > patch, so that other can then test they do not regress on the > functionality you have just added. > > That is why everybody including you has to test their patches also by > doing: > > make bootstrap > make -k check > > (with a -j level appropriate for your computer) and then collect *.sum > files from unpatched and patched runs and compare them (see script in > contrib/compare_tests) to make sure they did not introduce any > regressions. > > See section on "Testing patches" at https://gcc.gnu.org/contribute.html > for more details. > > Please ask about these mechanisms and conventions if anything is not > clear. I'll go and find the latest version of your roundeven patch and > see if I can help you a little (but I am likely to finish that only > tomorrow morning). > > Thanks, > > Martin
