On Wed, Apr 3, 2019 at 10:01 PM Martin Jambor <mjam...@suse.cz> wrote:
> Hello Shubham, > > On Fri, Mar 29 2019, Shubham Narlawar wrote: > > Hi, here is my proposal for the above idea. Please review and suggest > > necessary changes. > > > > > https://docs.google.com/document/d/11MNhuuD7dbwAfSW6ZgFrAys9My1Lw1PuMVcAqeNGr7A/edit?usp=sharing > > I have had a quick look and the proposal seems very nice. > > How did you select the attributes you want to implement in csmith? It > is for example a little strange that you decided to include "pure" but > not "const." If you handle visibility, you might as well consider > throwing in externally_visible too, I guess. As a stretch goal, the > alias function attribute might be useful to exercise nasty paths in GCC > IPA optimizations. > Thanks for the suggestion. I have added function attribute alias, const and externally_visible in my proposal. My bad, I forgot to add const. Also, suggest some more attributes like alias which will help to exercise different components of GCC, so that I can update my proposal accordingly. > > I assume Andi Kleen has seen this proposal and if he is fine with it, so > am I. > Yes. Thanks Shubham > Thanks, > > Martin > >
