On Sat, 2017-12-16 at 12:06 +0100, Paulo Matos wrote:
>
> On 15/12/17 15:29, David Malcolm wrote:
> > On Fri, 2017-12-15 at 10:16 +0100, Paulo Matos wrote:
> > >
> > > On 14/12/17 12:39, David Malcolm wrote:
> >
> > [...]
> >
> > > > It looks like you're capturing the textual output from "jv
> > > > compare"
> > > > and
> > > > using the exit code. Would you prefer to import "jv" as a
> > > > python
> > > > module and use some kind of API? Or a different output format?
> > > >
> > >
> > > Well, I am using a fork of it which I converted to Python3. Would
> > > you
> > > be
> > > open to convert yours to Python3? The reason I am doing this is
> > > because
> > > all other Python software I have and the buildbot use Python3.
> >
> > Done.
> >
> > I found and fixed some more bugs, also (introduced during my
> > refactoring, sigh...)
> >
>
> That's great. Thank you very much for this work.
>
> > > I would also prefer to have some json format or something but
> > > when I
> > > looked at it, the software was just printing to stdout and I
> > > didn't
> > > want
> > > to spend too much time implementing it, so I thought parsing the
> > > output
> > > was just easier.
> >
> > I can add JSON output (or whatever), but I need to get back to gcc
> > 8
> > work, so if the stdout output is good enough for now, let's defer
> > output changes.
> >
>
> Agree, for now I can use what I already have to read the output of
> jv.
> I think I can now delete my fork and just use upstream jv as a
> submodule.
I've added a new feature to jamais-vu (as of
77849e2809ca9a049d5683571e27ebe190977fa8): it can now ignore test
results that merely changed line number.
For example, if the old .sum file has a:
PASS: g++.dg/diagnostic/param-type-mismatch.C -std=gnu++11 (test for
errors, line 106)
and the new .sum file has a:
PASS: g++.dg/diagnostic/param-type-mismatch.C -std=gnu++11 (test for
errors, line 103)
and diffing the source trees reveals that line 106 became line 103, the
change won't be reported by "jv compare".
It also does it for dg-{begin|end}-multiline-output.
It will report them if the outcome changed (e.g. from PASS to FAIL).
To do this filtering, jv needs access to the old and new source trees,
so it can diff the pertinent source files, so "jv compare" has gained
the optional arguments
--old-source-path=
and
--new-source-path=
See the example in the jv Makefile for more info. If they're not
present, it should work as before (without being able to do the above
filtering).
Is this something that the buildbot can use?
Dave
