On Mon, Feb 17, 2014 at 07:59:16PM +0400, Ilya Verbin wrote:
> On 14 Feb 16:43, Jakub Jelinek wrote:
> > So, perhaps we should just stop for now oring the copyfrom in and just use
> > the copyfrom from the very first mapping only, and wait for what the
> > committee
> > actually agrees on.
> >
> > Jakub
>
> Like this?
>
> @@ -171,11 +171,16 @@ gomp_map_vars_existing (splay_tree_key oldn,
> splay_tree_key newn,
> "[%p..%p) is already mapped",
> (void *) newn->host_start, (void *) newn->host_end,
> (void *) oldn->host_start, (void *) oldn->host_end);
> +#if 0
> + /* FIXME: Remove this when OpenMP 4.0 will be standardized. Currently it's
> + unclear regarding overwriting copy_from for the existing mapping.
> + See http://gcc.gnu.org/ml/gcc/2014-02/msg00208.html for details. */
> if (((kind & 7) == 2 || (kind & 7) == 3)
> && !oldn->copy_from
> && oldn->host_start == newn->host_start
> && oldn->host_end == newn->host_end)
> oldn->copy_from = true;
> +#endif
> oldn->refcount++;
> }
Well, OpenMP 4.0 is a released standard, just in some cases ambiguous or
buggy. I'd just remove the code rather than putting it into #if 0, patch
preapproved. It will stay in the SVN history...
Jakub
