On Tue, Nov 12, 2013 at 11:52 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Tue, Nov 12, 2013 at 11:34:41AM +0400, Kostya Serebryany wrote: >> On Sun, Nov 10, 2013 at 10:34 PM, FX <fxcoud...@gmail.com> wrote: >> >> > > Unfortunately, we are not able to keep up with the old kernels. >> > > Two possible ways to go: >> > > - disable libsanitizer on older kernels >> > > - someone needs to work with us in upstream repository (llvm) to keep >> > the code old-kernel-compatible >> > >> > (It appears to be not only kernel, but binutils.) >> > >> > I think, at least the following should be done: >> > >> > - identify and document the minimal requirements >> > >> >> Agree. From our side we can only guarantee Ubuntu 12.04 and higher. > > For making sure libsanitizer at least compiles, just installing > /usr/include/ trees from a couple of important still supported distributions > from various eras and just using -isystem /path/to/distro1/usr/include/ as > additional (very quick) test of building the libraries on your bots > wouldn't be IMHO that difficult.
Then we'll be getting complaints like 'this stuff compiles but doesn't work'. Still might be worth doing. Maybe we could create a wiki page somewhere describing the test process that everyone should follow when submitting changes to libsanitizer? --kcc
