On Wed, 3 Nov 2010, Ian Lance Taylor wrote: > "Joseph S. Myers" <jos...@codesourcery.com> writes: > > > I think new front ends should be reviewed for general style, coding > > conventions, use of deprecated interfaces, unportabilities etc., just as > > new back ends should be reviewed. > > Would anybody care to volunteer to review the Go frontend on these > grounds? The code can be found on the gccgo branch in the gcc/go > subdirectory.
I have now posted reviews of this code for various issues, though I think it could do with more eyes on it, from front-end maintainers, build-system maintainers and others. I did not go exhaustively through all the code in gofrontend/. http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00640.html http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00654.html http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00656.html > There is also the libgo directory. The contents of libgo/go are a copy > of the standard Go library and I don't think a review of that would be > useful. But it would be reasonable to review the contents of libgo > outside of libgo/go. This code can found on the gccgo branch in the > libgo subdirectory. I don't propose to review this. A build-system maintainer might be most useful there. -- Joseph S. Myers jos...@codesourcery.com
